Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 11043031: Allow special java statements (for example imports) to be as long as neccessary. (Closed)

Created:
8 years, 2 months ago by Siva Chandra
Modified:
8 years, 2 months ago
Reviewers:
cmp, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Allow special java statements (for example imports) to be as long as neccessary. BUG=152209 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160956

Patch Set 1 #

Patch Set 2 : Better comment in the code #

Patch Set 3 : Added unit tests. #

Total comments: 1

Patch Set 4 : Modified test according to maruel's comment. #

Patch Set 5 : Fixed existing tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M git_cl.py View 1 2 3 4 3 chunks +7 lines, -0 lines 0 comments Download
M tests/git_cl_test.py View 1 2 3 4 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Siva Chandra
This CL allows package and import statements in java files to be as long as ...
8 years, 2 months ago (2012-10-03 22:01:07 UTC) #1
M-A Ruel
unit test?
8 years, 2 months ago (2012-10-04 01:10:34 UTC) #2
M-A Ruel
Also, please only set one code reviewer. If you have trouble finding a good one, ...
8 years, 2 months ago (2012-10-04 12:42:53 UTC) #3
Siva Chandra
Added unit tests and pruned the reviewer list to have only one reviewer.
8 years, 2 months ago (2012-10-04 19:15:29 UTC) #4
Siva Chandra
PING
8 years, 2 months ago (2012-10-09 20:30:38 UTC) #5
M-A Ruel
lgtm https://chromiumcodereview.appspot.com/11043031/diff/9001/tests/presubmit_unittest.py File tests/presubmit_unittest.py (right): https://chromiumcodereview.appspot.com/11043031/diff/9001/tests/presubmit_unittest.py#newcode1833 tests/presubmit_unittest.py:1833: self.ContentTest(check, 'import ' + 'A ' * 50, ...
8 years, 2 months ago (2012-10-09 21:39:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/11043031/12002
8 years, 2 months ago (2012-10-09 22:36:03 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-09 22:38:53 UTC) #8
Change committed as 160956

Powered by Google App Engine
This is Rietveld 408576698