Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Issue 11043012: [Sync] Notify invalidation handlers when sync is disabled/enabled (Closed)

Created:
8 years, 2 months ago by akalin
Modified:
8 years, 2 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, haitaol1, tim (not reviewing)
Visibility:
Public.

Description

[Sync] Notify invalidation handlers when sync is disabled/enabled BUG=137086 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160525

Patch Set 1 #

Patch Set 2 : Diff properly #

Patch Set 3 : Rebase #

Patch Set 4 : rebase #

Patch Set 5 : diff properly #

Total comments: 4

Patch Set 6 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -2 lines) Patch
M chrome/browser/sync/profile_sync_service.h View 1 2 3 4 5 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 3 4 5 5 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 2 3 4 5 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
akalin
+zea for review (note that this is based on https://codereview.chromium.org/11046008/ ).
8 years, 2 months ago (2012-10-02 22:10:21 UTC) #1
Nicolas Zea
is this diffed properly? It looks like it includes the changes from your other two ...
8 years, 2 months ago (2012-10-03 23:52:34 UTC) #2
akalin
On 2012/10/03 23:52:34, nzea wrote: > is this diffed properly? It looks like it includes ...
8 years, 2 months ago (2012-10-04 00:06:23 UTC) #3
Nicolas Zea
http://codereview.chromium.org/11043012/diff/18001/chrome/browser/sync/profile_sync_service.h File chrome/browser/sync/profile_sync_service.h (right): http://codereview.chromium.org/11043012/diff/18001/chrome/browser/sync/profile_sync_service.h#newcode718 chrome/browser/sync/profile_sync_service.h:718: // Must be called every time |backend_initialized_| or |state_| ...
8 years, 2 months ago (2012-10-04 00:21:00 UTC) #4
akalin
PTAL http://codereview.chromium.org/11043012/diff/18001/chrome/browser/sync/profile_sync_service.h File chrome/browser/sync/profile_sync_service.h (right): http://codereview.chromium.org/11043012/diff/18001/chrome/browser/sync/profile_sync_service.h#newcode718 chrome/browser/sync/profile_sync_service.h:718: // Must be called every time |backend_initialized_| or ...
8 years, 2 months ago (2012-10-05 21:35:16 UTC) #5
Nicolas Zea
lgtm
8 years, 2 months ago (2012-10-05 21:39:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/11043012/24002
8 years, 2 months ago (2012-10-05 21:47:37 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-06 00:04:50 UTC) #8
Change committed as 160525

Powered by Google App Engine
This is Rietveld 408576698