[Chromoting] Reimplemented the worker process launcher to take into account the encountered issues:

remoting/host/win/wts_console_session_process_driver.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_WIN_WTS_CONSOLE_SESSION_PROCESS_DRIVER_H_
+#define REMOTING_HOST_WIN_WTS_CONSOLE_SESSION_PROCESS_DRIVER_H_
+
+#include "base/compiler_specific.h"

[Wez, 2012/10/09 03:40:39]

nit: Remove the duplicate include.

[alexeypa (please no reviews), 2012/10/09 19:42:04]

Done.

+#include "base/callback_forward.h"
+#include "base/compiler_specific.h"
+#include "base/memory/ref_counted.h"
+#include "remoting/base/stoppable.h"
+#include "remoting/host/win/wts_console_observer.h"
+#include "remoting/host/worker_process_ipc_delegate.h"
+
+namespace base {
+class SingleThreadTaskRunner;
+} // namespace base
+
+namespace remoting {
+
+class WorkerProcessLauncher;
+class WtsConsoleMonitor;
+
+// Launches the host in the session attached to the console. When a new session
+// attaches to the console relaunches the host in it.
+class WtsConsoleSessionProcessDriver

[Wez, 2012/10/09 03:40:39]

WtsConsoleSessionProcessHost would be the Chrome-style name for this.

[alexeypa (please no reviews), 2012/10/09 19:42:04]

I'd like to avoid confusion. This class launches the host process so we end up
with "host" on both ends of the rope.

[Wez, 2012/10/10 00:52:03]

Good point.  I still don't like "Driver", though; let's re-name this class if we
can think of a better suffix at some point.

+    : public Stoppable,
+      public WorkerProcessIpcDelegate,
+      public WtsConsoleObserver {
+ public:
+  // Constructs a WtsConsoleSessionProcessDriver object. |stopped_callback| and
+  // |main_task_runner| are passed to the undelying |Stoppable| implementation.

[Wez, 2012/10/09 03:40:39]

typo: undelying

[Wez, 2012/10/09 03:40:39]

nit: |main_task_runner| is also passed to the WorkerProcessLauncher

[alexeypa (please no reviews), 2012/10/09 19:42:04]

Done.

[alexeypa (please no reviews), 2012/10/09 19:42:04]

Done.

+  // All interaction with |monitor| should happen on |main_task_runner|.

[Wez, 2012/10/09 03:40:39]

nit: This is a property of the implementation; do you mean to say this
implementation _will_ only access |monitor| on |main_task_runner|?

[alexeypa (please no reviews), 2012/10/09 19:42:04]

Done.

+  // |io_task_runner| must be an I/O message loop.
+  WtsConsoleSessionProcessDriver(
+      const base::Closure& stopped_callback,
+      WtsConsoleMonitor* monitor,
+      scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,

[Wez, 2012/10/09 03:40:39]

nit: Consider |monitor_task_runner| or |caller_task_runner|, or, if possible,
grab it implicitly via ThreadTaskRunnerHandle.

[alexeypa (please no reviews), 2012/10/09 19:42:04]

Done. |caller_task_runner|

+      scoped_refptr<base::SingleThreadTaskRunner> io_task_runner);
+
+  virtual ~WtsConsoleSessionProcessDriver();
+
+  // WorkerProcessIpcDelegate implementation.
+  virtual void OnChannelConnected() OVERRIDE;
+  virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+  virtual void OnPermanentError() OVERRIDE;
+
+  // WtsConsoleObserver implementation.
+  virtual void OnSessionAttached(uint32 session_id) OVERRIDE;
+  virtual void OnSessionDetached() OVERRIDE;
+
+ protected:
+  // Stoppable implementation.
+  virtual void DoStop() OVERRIDE;
+
+ private:
+  // The task runner all public methods of this class should be called on.

[Wez, 2012/10/09 03:40:39]

nit: "The task runner..." -> "Task runner on which public methods must be
called".

If that were true then you could derived this class from base::NonThreadSafe to
avoid the need to hold this reference.

This task runner is actually passed through to WorkerProcessLauncher, though,
isn't it, so it's not just used for that?

[alexeypa (please no reviews), 2012/10/09 19:42:04]

Done.
I need this reference anyway to pass it to other classes.
This is not the only purpose. It is used to do asynchronous shutdown via
Stoppable.

+  scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_;
+
+  // Message loop used by the IPC channel.
+  scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
+
+  // Launches and monitors the worker process.
+  scoped_refptr<WorkerProcessLauncher> launcher_;
+
+  // This pointer is used to unsubscribe from session attach and detach events.

[Wez, 2012/10/09 03:40:39]

nit: Drop "This point is"

[alexeypa (please no reviews), 2012/10/09 19:42:04]

Done.

+  WtsConsoleMonitor* monitor_;
+
+  DISALLOW_COPY_AND_ASSIGN(WtsConsoleSessionProcessDriver);
+};
+
+}  // namespace remoting
+
+#endif  // REMOTING_HOST_WIN_WTS_CONSOLE_SESSION_PROCESS_DRIVER_H_