Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 11040051: Copy PP_Vars in ppapi test PluginVectorReceiveInput so we can test their refcount. (Closed)

Created:
8 years, 2 months ago by raymes
Modified:
8 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Copy PP_Vars in ppapi test PluginVectorReceiveInput so we can test their refcount. Previously when |SerializedVarVectorReceiveInput| objects went out of scope, their associated arrays were destroyed which led to use-after-frees when testing refcounts. This corrects the problem by making a copy of the array. BUG=152298 TEST=valgrinded the test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M ppapi/proxy/serialized_var_unittest.cc View 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
raymes
8 years, 2 months ago (2012-10-05 00:13:25 UTC) #1
raymes
dmichael is OOO. No hurry on this though.
8 years, 2 months ago (2012-10-05 21:37:39 UTC) #2
dmichael (off chromium)
lgtm
8 years, 2 months ago (2012-10-05 22:40:24 UTC) #3
raymes
Thanks! On Fri, Oct 5, 2012 at 3:40 PM, <dmichael@chromium.org> wrote: > lgtm > > ...
8 years, 2 months ago (2012-10-05 22:41:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/11040051/1
8 years, 2 months ago (2012-10-05 22:43:58 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-06 02:06:22 UTC) #6
Change committed as 160545

Powered by Google App Engine
This is Rietveld 408576698