Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 11040031: Fix zoom icon/bubble for virtual URLs (i.e. chrome://settings). (Closed)

Created:
8 years, 2 months ago by Dan Beam
Modified:
8 years, 2 months ago
Reviewers:
Kyle Horimoto, brettw, sky
CC:
chromium-reviews, brettw
Visibility:
Public.

Description

Fix zoom icon/bubble for virtual URLs (i.e. chrome://settings). R=khorimoto@chromium.org,sky@chromium.org BUG=153950 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160228

Patch Set 1 #

Total comments: 5

Patch Set 2 : fix #

Patch Set 3 : doc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/ui/zoom/zoom_controller.cc View 1 2 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Dan Beam
8 years, 2 months ago (2012-10-04 01:32:03 UTC) #1
Dan Beam
+sky for OWNERS
8 years, 2 months ago (2012-10-04 01:32:28 UTC) #2
Kyle Horimoto
https://codereview.chromium.org/11040031/diff/1/chrome/browser/ui/zoom/zoom_controller.cc File chrome/browser/ui/zoom/zoom_controller.cc (right): https://codereview.chromium.org/11040031/diff/1/chrome/browser/ui/zoom/zoom_controller.cc#newcode93 chrome/browser/ui/zoom/zoom_controller.cc:93: } else { When exactly is active_entry NULL? A ...
8 years, 2 months ago (2012-10-04 03:00:21 UTC) #3
Dan Beam
https://codereview.chromium.org/11040031/diff/1/chrome/browser/ui/zoom/zoom_controller.cc File chrome/browser/ui/zoom/zoom_controller.cc (right): https://codereview.chromium.org/11040031/diff/1/chrome/browser/ui/zoom/zoom_controller.cc#newcode93 chrome/browser/ui/zoom/zoom_controller.cc:93: } else { On 2012/10/04 03:00:22, Kyle Horimoto wrote: ...
8 years, 2 months ago (2012-10-04 03:13:04 UTC) #4
sky
LGTM https://codereview.chromium.org/11040031/diff/1/chrome/browser/ui/zoom/zoom_controller.cc File chrome/browser/ui/zoom/zoom_controller.cc (right): https://codereview.chromium.org/11040031/diff/1/chrome/browser/ui/zoom/zoom_controller.cc#newcode90 chrome/browser/ui/zoom/zoom_controller.cc:90: // Prefer to ask the navigation controller for ...
8 years, 2 months ago (2012-10-04 16:01:12 UTC) #5
Dan Beam
https://codereview.chromium.org/11040031/diff/1/chrome/browser/ui/zoom/zoom_controller.cc File chrome/browser/ui/zoom/zoom_controller.cc (right): https://codereview.chromium.org/11040031/diff/1/chrome/browser/ui/zoom/zoom_controller.cc#newcode90 chrome/browser/ui/zoom/zoom_controller.cc:90: // Prefer to ask the navigation controller for the ...
8 years, 2 months ago (2012-10-04 16:03:10 UTC) #6
Kyle Horimoto
On 2012/10/04 03:13:04, Dan Beam wrote: > https://codereview.chromium.org/11040031/diff/1/chrome/browser/ui/zoom/zoom_controller.cc > File chrome/browser/ui/zoom/zoom_controller.cc (right): > > https://codereview.chromium.org/11040031/diff/1/chrome/browser/ui/zoom/zoom_controller.cc#newcode93 ...
8 years, 2 months ago (2012-10-04 16:49:18 UTC) #7
Dan Beam
On 2012/10/04 16:49:18, Kyle Horimoto wrote: > On 2012/10/04 03:13:04, Dan Beam wrote: > > ...
8 years, 2 months ago (2012-10-04 17:09:56 UTC) #8
Kyle Horimoto
LGTM Looks fine to me assuming this behaves how we think it does - I'll ...
8 years, 2 months ago (2012-10-04 17:20:53 UTC) #9
brettw
The active entry can be null in some cases like if a popup is opened ...
8 years, 2 months ago (2012-10-04 18:18:55 UTC) #10
Dan Beam
On 2012/10/04 18:18:55, brettw wrote: > The active entry can be null in some cases ...
8 years, 2 months ago (2012-10-04 18:43:08 UTC) #11
Dan Beam
https://chromiumcodereview.appspot.com/11040031/diff/1/chrome/browser/ui/zoom/zoom_controller.cc File chrome/browser/ui/zoom/zoom_controller.cc (right): https://chromiumcodereview.appspot.com/11040031/diff/1/chrome/browser/ui/zoom/zoom_controller.cc#newcode90 chrome/browser/ui/zoom/zoom_controller.cc:90: // Prefer to ask the navigation controller for the ...
8 years, 2 months ago (2012-10-04 19:05:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/11040031/3
8 years, 2 months ago (2012-10-04 19:06:40 UTC) #13
commit-bot: I haz the power
8 years, 2 months ago (2012-10-04 21:07:32 UTC) #14
Change committed as 160228

Powered by Google App Engine
This is Rietveld 408576698