Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 11040008: Roll v8-i18n 143:150. (Closed)

Created:
8 years, 2 months ago by Nebojša Ćirić
Modified:
8 years, 2 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, Erik Corry, arv (Not doing code reviews)
Visibility:
Public.

Description

Roll v8-i18n 143:150. This change introduces Intl global object. The original v8Intl is aliased to Intl to prevent client problems (ChromeOS, Drive, some Chrome apps). The Intl name is part of new ECMA 402 standard. See https://codereview.appspot.com/6598047/ for details. TEST=Open console in Chrome. Both Intl and v8Intl should be there. v8Intl === Intl. BUG=28604 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159741

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nebojša Ćirić
PTL
8 years, 2 months ago (2012-10-01 21:09:06 UTC) #1
jungshik at Google
LGTM
8 years, 2 months ago (2012-10-02 17:17:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cira@chromium.org/11040008/1
8 years, 2 months ago (2012-10-02 17:44:34 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-02 19:32:19 UTC) #4
Change committed as 159741

Powered by Google App Engine
This is Rietveld 408576698