Bring up of ui/text/elider on iOS.

Bring up of ui/text/elider on iOS.

Unfortunately there is an issue with font metrics on the platform that cause some tests to fail. See
crbug.com/154019 for details.

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162814

[noyau (Ping after 24h), 2012-10-05 09:15:19]

To Stuart for initial review.

[stuartmorgan, 2012-10-05 12:05:43]

Rather than ifdefing based on essentially random float rounding outcomes, I
think we should just DISABLED_ these two tests on iOS for now.

[noyau (Ping after 24h), 2012-10-05 13:16:58]

PTAL.

[stuartmorgan, 2012-10-06 11:47:04]

https://codereview.chromium.org/11038059/diff/1004/ui/base/text/text_elider_u...
File ui/base/text/text_elider_unittest.cc (right):

https://codereview.chromium.org/11038059/diff/1004/ui/base/text/text_elider_u...
ui/base/text/text_elider_unittest.cc:59: // TODO(ios): complex eliding is off by
one for some of those tests on iOS.
Don't indent.

https://codereview.chromium.org/11038059/diff/1004/ui/base/text/text_elider_u...
ui/base/text/text_elider_unittest.cc:61: TEST(TextEliderTest,
DISABLED_ElideEmail) {
The standard Chromium practice is to use MAYBE_.  See
http://code.google.com/searchframe#OAMlx_jo-ck/src/net/base/cert_verify_proc_...
for an example.

https://codereview.chromium.org/11038059/diff/1004/ui/base/text/text_elider_u...
ui/base/text/text_elider_unittest.cc:64: #endif  // defined(OS_IOS)
We generally omit the closing comment on ifdefs that are very short and we know
will stay that way, since in those cases they often hurt readability more than
they help.

[noyau (Ping after 24h), 2012-10-08 07:52:33]

Now using MAYBE_.

[stuartmorgan, 2012-10-08 08:10:12]

LGTM with nit.

https://codereview.chromium.org/11038059/diff/16001/ui/base/text/text_elider_...
File ui/base/text/text_elider_unittest.cc (right):

https://codereview.chromium.org/11038059/diff/16001/ui/base/text/text_elider_...
ui/base/text/text_elider_unittest.cc:58: // TODO(ios): complex eliding is off by
one for some of those tests on iOS.
s/complex/Complex/

https://codereview.chromium.org/11038059/diff/16001/ui/base/text/text_elider_...
ui/base/text/text_elider_unittest.cc:257: // TODO(ios): complex eliding is off
by one for some of those tests on iOS.
Same.

[noyau (Ping after 24h), 2012-10-08 09:59:29]

To thakis for owner review.

https://codereview.chromium.org/11038059/diff/16001/ui/base/text/text_elider_...
File ui/base/text/text_elider_unittest.cc (right):

https://codereview.chromium.org/11038059/diff/16001/ui/base/text/text_elider_...
ui/base/text/text_elider_unittest.cc:58: // TODO(ios): complex eliding is off by
one for some of those tests on iOS.
On 2012/10/08 08:10:12, stuartmorgan wrote:
> s/complex/Complex/

Done.

https://codereview.chromium.org/11038059/diff/16001/ui/base/text/text_elider_...
ui/base/text/text_elider_unittest.cc:257: // TODO(ios): complex eliding is off
by one for some of those tests on iOS.
On 2012/10/08 08:10:12, stuartmorgan wrote:
> Same.

Done.

[Nico, 2012-10-17 22:27:39]

lgtm

Sorry, I missed this after returning from vacation. Please ping when I don't
respond to coe reviews :-)

[commit-bot: I haz the power, 2012-10-18 21:00:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noyau@chromium.org/11038059/26001

[commit-bot: I haz the power, 2012-10-18 22:21:06]

Change committed as 162814