Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 11038058: Change visibility of the destructor to public. (Closed)

Created:
8 years, 2 months ago by lpromero-g
Modified:
8 years, 2 months ago
Reviewers:
Mark Mentovai, M-A Ruel
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Change visibility of the destructor to public. PlatformTest's destructor was set as protected, though the parent class testing::Test declares it public. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M testing/platform_test.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
lpromero-g
8 years, 2 months ago (2012-10-05 07:55:46 UTC) #1
M-A Ruel
This means this class should be deleted by a pointer to its base class. I ...
8 years, 2 months ago (2012-10-05 10:48:15 UTC) #2
lpromero-g
On 2012/10/05 10:48:15, Marc-Antoine Ruel wrote: > This means this class should be deleted by ...
8 years, 2 months ago (2012-10-05 10:52:09 UTC) #3
Mark Mentovai
LGTM
8 years, 2 months ago (2012-10-11 14:07:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lpromero@google.com/11038058/1
8 years, 2 months ago (2012-10-11 14:10:08 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-11 16:08:12 UTC) #6
Change committed as 161352

Powered by Google App Engine
This is Rietveld 408576698