Issue 11038016: Fix bug with mint unboxing on non-SSE 4.1 machines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11038016: Fix bug with mint unboxing on non-SSE 4.1 machines. (Closed)

Created:
8 years, 2 months ago by Florian Schneider

Modified:
8 years, 2 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug with mint unboxing on non-SSE 4.1 machines. I forgot to check for SSE 4.1 support in one place. For machines that do not support SSE 4.1 we should never generated unboxed mint operations. Committed: https://code.google.com/p/dart/source/detail?r=13164

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -7 lines)			Patch
M	runtime/vm/assembler_ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages