Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chrome/common/chrome_notification_types.h

Issue 11038014: [Android] Upstream remaining changes to NTP UI code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed indentation nit Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser_ui.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_notification_types.h
diff --git a/chrome/common/chrome_notification_types.h b/chrome/common/chrome_notification_types.h
index efba24f3fd59c74ba8b23aa5b8bf294607e96044..b438f4c8abedc6b263bc0c4ba5c7b05434daa8c1 100644
--- a/chrome/common/chrome_notification_types.h
+++ b/chrome/common/chrome_notification_types.h
@@ -151,6 +151,17 @@ enum NotificationType {
// starting and finishing all painting.
NOTIFICATION_INITIAL_NEW_TAB_UI_LOAD,
+#if defined(OS_ANDROID)
sky 2012/10/09 00:35:25 Why is this android specific?
newt (away) 2012/10/09 09:49:27 We added the event to reduce flakiness for tests t
sky 2012/10/09 15:59:13 Ok. From the description it seemed like it might b
+ // Indicates that the new tab page is ready. This is different than
+ // NOTIFICATION_INITIAL_NEW_TAB_UI_LOAD as the NTP might do some more in-page
+ // navigations after it's done loading, potentially causing flakyness in tests
+ // that would navigate as soon as the NTP is done loading.
+ // When this notification happen, it guarantees the page is not going to do
+ // any further navigation.
+ // The source is the TabContents containing the NTP.
+ NOTIFICATION_NEW_TAB_READY,
+#endif
+
// Used to fire notifications about how long various events took to
// complete. E.g., this is used to get more fine grained timings from the
// new tab page. The source is a WebContents and the details is a
« no previous file with comments | « chrome/chrome_browser_ui.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698