- WeakProperty keys in other generations are black. Avoid trying to

vm/object_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
@@ skipping 2847 matching lines @@
       "#4      MyClass.field (dart:test-lib:25:9)\n"
       "#5      MyClass.foo.fooHelper (dart:test-lib:30:7)\n"
       "#6      MyClass.foo (dart:test-lib:32:14)\n"
       "#7      MyClass.MyClass.<anonymous closure> (dart:test-lib:21:15)\n"
       "#8      MyClass.MyClass (dart:test-lib:21:18)\n"
       "#9      main.<anonymous closure> (dart:test-lib:37:10)\n"
       "#10     main (dart:test-lib:37:24)");
 }
 
 
+TEST_CASE(WeakProperty_PreserveCrossGen) {
+  Isolate* isolate = Isolate::Current();
+  WeakProperty& weak = WeakProperty::Handle();
+  {
+    // Weak property and value in new. Key in old.
+    HANDLESCOPE(isolate);
+    OneByteString& key = OneByteString::Handle();
+    key ^= OneByteString::New("key", Heap::kOld);
+    OneByteString& value = OneByteString::Handle();
+    value ^= OneByteString::New("value", Heap::kNew);
+    weak ^= WeakProperty::New(Heap::kNew);
+    weak.set_key(key);
+    weak.set_value(value);
+    key ^= OneByteString::null();
+    value ^= OneByteString::null();
+  }
+  isolate->heap()->CollectAllGarbage();
+  // Weak property key and value should survive due to cross-generation
+  // pointers.
+  EXPECT(weak.key() != Object::null());
+  EXPECT(weak.value() != Object::null());
+  {
+    // Weak property and value in old. Key in new.
+    HANDLESCOPE(isolate);
+    OneByteString& key = OneByteString::Handle();
+    key ^= OneByteString::New("key", Heap::kNew);
+    OneByteString& value = OneByteString::Handle();
+    value ^= OneByteString::New("value", Heap::kOld);
+    weak ^= WeakProperty::New(Heap::kOld);
+    weak.set_key(key);
+    weak.set_value(value);
+    key ^= OneByteString::null();
+    value ^= OneByteString::null();
+  }
+  isolate->heap()->CollectAllGarbage();
+  // Weak property key and value should survive due to cross-generation
+  // pointers.
+  EXPECT(weak.key() != Object::null());
+  EXPECT(weak.value() != Object::null());
+  {
+    // Weak property and value in new. Key is a Smi.
+    HANDLESCOPE(isolate);
+    Integer& key = Integer::Handle();
+    key ^= Integer::New(31);
+    OneByteString& value = OneByteString::Handle();
+    value ^= OneByteString::New("value", Heap::kNew);
+    weak ^= WeakProperty::New(Heap::kNew);
+    weak.set_key(key);
+    weak.set_value(value);
+    key ^= Integer::null();
+    value ^= OneByteString::null();
+  }
+  isolate->heap()->CollectAllGarbage();
+  // Weak property key and value should survive due to cross-generation

[cshapiro, 2012/10/01 22:22:14]

This comment is false, no?  The key is implicitly live because it is not a heap
object.

[Ivan Posva, 2012/10/01 22:27:39]

Done.

+  // pointers.
+  EXPECT(weak.key() != Object::null());
+  EXPECT(weak.value() != Object::null());
+  {
+    // Weak property and value in old. Key is a Smi.
+    HANDLESCOPE(isolate);
+    Integer& key = Integer::Handle();
+    key ^= Integer::New(32);
+    OneByteString& value = OneByteString::Handle();
+    value ^= OneByteString::New("value", Heap::kOld);
+    weak ^= WeakProperty::New(Heap::kOld);
+    weak.set_key(key);
+    weak.set_value(value);
+    key ^= OneByteString::null();
+    value ^= OneByteString::null();
+  }
+  isolate->heap()->CollectAllGarbage();
+  // Weak property key and value should survive due to cross-generation

[cshapiro, 2012/10/01 22:22:14]

Same here.

[Ivan Posva, 2012/10/01 22:27:39]

Done.

+  // pointers.
+  EXPECT(weak.key() != Object::null());
+  EXPECT(weak.value() != Object::null());
+  {
+    // Weak property and value in new. Key in VM isolate.
+    HANDLESCOPE(isolate);
+    OneByteString& key = OneByteString::Handle();
+    key ^= Symbols::Dot();
+    OneByteString& value = OneByteString::Handle();
+    value ^= OneByteString::New("value", Heap::kNew);
+    weak ^= WeakProperty::New(Heap::kNew);
+    weak.set_key(key);
+    weak.set_value(value);
+    key ^= OneByteString::null();
+    value ^= OneByteString::null();
+  }
+  isolate->heap()->CollectAllGarbage();
+  // Weak property key and value should survive due to cross-generation
+  // pointers.
+  EXPECT(weak.key() != Object::null());
+  EXPECT(weak.value() != Object::null());
+  {
+    // Weak property and value in old. Key in VM isolate.
+    HANDLESCOPE(isolate);
+    OneByteString& key = OneByteString::Handle();
+    key ^= Symbols::Dot();
+    OneByteString& value = OneByteString::Handle();
+    value ^= OneByteString::New("value", Heap::kOld);
+    weak ^= WeakProperty::New(Heap::kOld);
+    weak.set_key(key);
+    weak.set_value(value);
+    key ^= OneByteString::null();
+    value ^= OneByteString::null();
+  }
+  isolate->heap()->CollectAllGarbage();
+  // Weak property key and value should survive due to cross-generation
+  // pointers.
+  EXPECT(weak.key() != Object::null());
+  EXPECT(weak.value() != Object::null());
+}
+
+
 TEST_CASE(WeakProperty_PreserveOne_NewSpace) {
   Isolate* isolate = Isolate::Current();
   WeakProperty& weak = WeakProperty::Handle();
   OneByteString& key = OneByteString::Handle();
   key ^= OneByteString::New("key");
   {
     HANDLESCOPE(isolate);
     OneByteString& value = OneByteString::Handle();
     value ^= OneByteString::New("value");
     weak ^= WeakProperty::New();
@@ skipping 228 matching lines @@
   isolate->heap()->CollectAllGarbage();
   EXPECT(weak1.key() == Object::null());
   EXPECT(weak1.value() == Object::null());
   EXPECT(weak2.key() == Object::null());
   EXPECT(weak2.value() == Object::null());
 }
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart