Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 11036054: Change the directory containing hyphenation dictionaries. (Closed)

Created:
8 years, 2 months ago by Hironori Bono
Modified:
8 years, 2 months ago
Reviewers:
tony, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Change the directory containing hyphenation dictionaries. Even though content shell and DumpRenderTree can use sample dictionaries in 'third_party/hyphen', Chrome cannot use them and it needs to use dictionaries downloaded to 'chrome::DIR_APP_DICTIONARIES'. This change adds the ContentBrowserClient::GetHyphenDictionaryDirectory function so Chrome can change the directory to 'chrome::DIR_APP_DICTIONARIES' and read hyphenation dictionaries from the directory. BUG=47083 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161845

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/hyphenator/hyphenator_message_filter.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Hironori Bono
Greetings Tony and John, Thank you for your help in advance. Even though this change ...
8 years, 2 months ago (2012-10-09 05:34:28 UTC) #1
tony
This is because in chrome, we want the hyphenation dictionaries in chrome::DIR_APP_DICTIONARIES, but the code ...
8 years, 2 months ago (2012-10-09 17:28:03 UTC) #2
jam
lgtm https://codereview.chromium.org/11036054/diff/1/content/browser/hyphenator/hyphenator_message_filter.cc File content/browser/hyphenator/hyphenator_message_filter.cc (right): https://codereview.chromium.org/11036054/diff/1/content/browser/hyphenator/hyphenator_message_filter.cc#newcode15 content/browser/hyphenator/hyphenator_message_filter.cc:15: #include "content/public/common/content_client.h" nit: get rid of this, content_browser_client.h ...
8 years, 2 months ago (2012-10-10 20:09:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/11036054/25001
8 years, 2 months ago (2012-10-15 08:25:20 UTC) #4
Hironori Bono
Greetings Tony and John, Thank you for your review and comments. I have updated the ...
8 years, 2 months ago (2012-10-15 08:26:28 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-15 10:12:15 UTC) #6
Change committed as 161845

Powered by Google App Engine
This is Rietveld 408576698