Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Issue 11035051: Screen Magnifier: Change keyboard shortcut from [CTRL + brightness] to [CTRL + ALT + brightness] (Closed)

Created:
8 years, 2 months ago by yoshiki
Modified:
8 years, 2 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, mazda+watch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Screen Magnifier: Change keyboard shortcut from [CTRL + brightness] to [CTRL + ALT + brightness] BUG=153961 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160776 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163797

Patch Set 1 #

Patch Set 2 : Changed modifier key from 'alt' to 'alt+ctrl' #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ash/accelerators/accelerator_table.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
yoshiki
derat: could you take a look?
8 years, 2 months ago (2012-10-05 07:19:28 UTC) #1
Daniel Erat
lgtm
8 years, 2 months ago (2012-10-05 14:16:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11035051/2001
8 years, 2 months ago (2012-10-09 00:20:27 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) interactive_ui_tests
8 years, 2 months ago (2012-10-09 01:06:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11035051/2001
8 years, 2 months ago (2012-10-09 01:42:07 UTC) #5
commit-bot: I haz the power
Change committed as 160776
8 years, 2 months ago (2012-10-09 02:45:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11035051/2001
8 years, 2 months ago (2012-10-24 05:59:06 UTC) #7
commit-bot: I haz the power
Failed to apply patch for ash/accelerators/accelerator_table.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
8 years, 2 months ago (2012-10-24 05:59:08 UTC) #8
yoshiki
Committing this patch again.
8 years, 2 months ago (2012-10-24 05:59:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11035051/20001
8 years, 2 months ago (2012-10-24 06:52:09 UTC) #10
commit-bot: I haz the power
8 years, 2 months ago (2012-10-24 09:06:54 UTC) #11
Change committed as 163797

Powered by Google App Engine
This is Rietveld 408576698