Issue 11035036: Fix wallpaper change on login screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11035036: Fix wallpaper change on login screen. (Closed)

Created:
8 years, 2 months ago by Nikita (slow)

Modified:
8 years, 2 months ago

Reviewers:
Ivan Korotkov

CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix wallpaper change on login screen. * Wallpaper is changed if needed when user is activated with click * Correct wallpaper is shown after user is deleted Speedup: load wallpaper without timeout when activated with click as opposed to activation with keyboard. BUG=153040, 153423 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160358

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : revert #

Patch Set 4 : cleanup #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
	M	chrome/browser/resources/chromeos/login/user_pod_row.js	View	1 2 3	6 chunks	+15 lines, -4 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

http://codereview.chromium.org/11035036/diff/3003/chrome/browser/resources/chromeos/login/user_pod_row.js File chrome/browser/resources/chromeos/login/user_pod_row.js (left): http://codereview.chromium.org/11035036/diff/3003/chrome/browser/resources/chromeos/login/user_pod_row.js#oldcode660 chrome/browser/resources/chromeos/login/user_pod_row.js:660: this.firstShown_ = false; firstShown was never reset

8 years, 2 months ago (2012-10-04 18:16:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/11035036/3003

8 years, 2 months ago (2012-10-05 09:10:34 UTC) #3

Change committed as 160358

Expand Messages | Collapse Messages