Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(67)

Issue 11035036: Fix wallpaper change on login screen. (Closed)

Created:
5 years, 2 months ago by Nikita (slow)
Modified:
5 years, 2 months ago
Reviewers:
Ivan Korotkov
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Fix wallpaper change on login screen. * Wallpaper is changed if needed when user is activated with click * Correct wallpaper is shown after user is deleted Speedup: load wallpaper without timeout when activated with click as opposed to activation with keyboard. BUG=153040, 153423 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160358

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : revert #

Patch Set 4 : cleanup #

Total comments: 1

Messages

Total messages: 4 (0 generated)
Nikita (slow)
http://codereview.chromium.org/11035036/diff/3003/chrome/browser/resources/chromeos/login/user_pod_row.js File chrome/browser/resources/chromeos/login/user_pod_row.js (left): http://codereview.chromium.org/11035036/diff/3003/chrome/browser/resources/chromeos/login/user_pod_row.js#oldcode660 chrome/browser/resources/chromeos/login/user_pod_row.js:660: this.firstShown_ = false; firstShown was never reset
5 years, 2 months ago (2012-10-04 18:16:45 UTC) #1
Ivan Korotkov
lgtm
5 years, 2 months ago (2012-10-05 08:25:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/11035036/3003
5 years, 2 months ago (2012-10-05 09:10:34 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2012-10-05 12:57:59 UTC) #4
Change committed as 160358

Powered by Google App Engine
This is Rietveld 0eb02b776