Chromium Code Reviews
Help | Chromium Project | Sign in
(70)

Issue 11035036: Fix wallpaper change on login screen. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by Nikita
Modified:
2 years, 10 months ago
Reviewers:
Ivan Korotkov
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Fix wallpaper change on login screen. * Wallpaper is changed if needed when user is activated with click * Correct wallpaper is shown after user is deleted Speedup: load wallpaper without timeout when activated with click as opposed to activation with keyboard. BUG=153040, 153423 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160358

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : revert #

Patch Set 4 : cleanup #

Total comments: 1

Messages

Total messages: 4 (0 generated)
Nikita
http://codereview.chromium.org/11035036/diff/3003/chrome/browser/resources/chromeos/login/user_pod_row.js File chrome/browser/resources/chromeos/login/user_pod_row.js (left): http://codereview.chromium.org/11035036/diff/3003/chrome/browser/resources/chromeos/login/user_pod_row.js#oldcode660 chrome/browser/resources/chromeos/login/user_pod_row.js:660: this.firstShown_ = false; firstShown was never reset
2 years, 10 months ago (2012-10-04 18:16:45 UTC) #1
Ivan Korotkov
lgtm
2 years, 10 months ago (2012-10-05 08:25:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/11035036/3003
2 years, 10 months ago (2012-10-05 09:10:34 UTC) #3
commit-bot: I haz the power
2 years, 10 months ago (2012-10-05 12:57:59 UTC) #4
Change committed as 160358
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5