Chromium Code Reviews
Help | Chromium Project | Sign in
(189)

Issue 11035036: Fix wallpaper change on login screen. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Nikita Kostylev
Modified:
1 year, 6 months ago
Reviewers:
Ivan Korotkov
CC:
chromium-reviews_chromium.org, arv, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Fix wallpaper change on login screen.
* Wallpaper is changed if needed when user is activated with click
* Correct wallpaper is shown after user is deleted

Speedup: load wallpaper without timeout when activated with click as opposed
to activation with keyboard.

BUG=153040, 153423
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160358

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : revert #

Patch Set 4 : cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Lint Patch
M chrome/browser/resources/chromeos/login/user_pod_row.js View 1 2 3 6 chunks +15 lines, -4 lines 1 comment ? errors Download
Commit:

Messages

Total messages: 4
Nikita Kostylev
http://codereview.chromium.org/11035036/diff/3003/chrome/browser/resources/chromeos/login/user_pod_row.js File chrome/browser/resources/chromeos/login/user_pod_row.js (left): http://codereview.chromium.org/11035036/diff/3003/chrome/browser/resources/chromeos/login/user_pod_row.js#oldcode660 chrome/browser/resources/chromeos/login/user_pod_row.js:660: this.firstShown_ = false; firstShown was never reset
1 year, 6 months ago #1
Ivan Korotkov
lgtm
1 year, 6 months ago #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/11035036/3003
1 year, 6 months ago #3
I haz the power (commit-bot)
1 year, 6 months ago #4
Change committed as 160358
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6