Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 11034009: Temporary fix bug in disabling sync for default apps (Closed)

Created:
8 years, 2 months ago by Gaurav
Modified:
8 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Temporary fix bug in disabling sync for default apps We added a new creation_flag for default apps was_installed_by_default, but every time we add a new creation_flag, we need to update the installedLoader as it does not directly pick the creation_flags but re-creates them through other preferences. This is temporary fix for M-23 branch. A more fundamental fix is 10977048 BUG=152582 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159612

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/extensions/installed_loader.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Gaurav
8 years, 2 months ago (2012-10-01 20:27:46 UTC) #1
Mihai Parparita -not on Chrome
LGTM On Mon, Oct 1, 2012 at 1:27 PM, <grv@chromium.org> wrote: > Reviewers: Mihai Parparita, ...
8 years, 2 months ago (2012-10-01 20:28:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/11034009/1
8 years, 2 months ago (2012-10-01 23:31:38 UTC) #3
commit-bot: I haz the power
8 years, 2 months ago (2012-10-02 01:42:18 UTC) #4
Change committed as 159612

Powered by Google App Engine
This is Rietveld 408576698