DevTools: [remote debugging] introduce json/new and json/close for creating and closing the tabs.

DevTools: [remote debugging] introduce json/new and json/close for creating and closing the tabs.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161126

[yurys, 2012-10-05 14:29:48]

https://chromiumcodereview.appspot.com/11033046/diff/5002/chrome/browser/debu...
File chrome/browser/debugger/browser_list_tabcontents_provider.cc (right):

https://chromiumcodereview.appspot.com/11033046/diff/5002/chrome/browser/debu...
chrome/browser/debugger/browser_list_tabcontents_provider.cc:90: TabContents*
tab_contents = chrome::AddSelectedTabWithURL(
Should we specify browser instance where to create the target?

https://chromiumcodereview.appspot.com/11033046/diff/5002/content/browser/deb...
File content/browser/debugger/devtools_http_handler_impl.cc (right):

https://chromiumcodereview.appspot.com/11033046/diff/5002/content/browser/deb...
content/browser/debugger/devtools_http_handler_impl.cc:421:
SendJson(connection_id, info, *dictionary.get());
*dictionary.get() -> *dictionary

https://chromiumcodereview.appspot.com/11033046/diff/5002/content/browser/deb...
content/browser/debugger/devtools_http_handler_impl.cc:643:
base::StringPrintf("ws://%s/devtools/page/%s",
wrong alignment

https://chromiumcodereview.appspot.com/11033046/diff/5002/content/shell/shell...
File content/shell/shell_devtools_delegate.h (right):

https://chromiumcodereview.appspot.com/11033046/diff/5002/content/shell/shell...
content/shell/shell_devtools_delegate.h:21: explicit
ShellDevToolsDelegate(BrowserContext* browser_context, int port);
No need for explicit.

https://chromiumcodereview.appspot.com/11033046/diff/5002/content/shell/shell...
File content/shell/shell_devtools_delegate_android.cc (right):

https://chromiumcodereview.appspot.com/11033046/diff/5002/content/shell/shell...
content/shell/shell_devtools_delegate_android.cc:15: 
Revert this line.

[pfeldman, 2012-10-05 14:36:47]

https://chromiumcodereview.appspot.com/11033046/diff/5002/chrome/browser/debu...
File chrome/browser/debugger/browser_list_tabcontents_provider.cc (right):

https://chromiumcodereview.appspot.com/11033046/diff/5002/chrome/browser/debu...
chrome/browser/debugger/browser_list_tabcontents_provider.cc:90: TabContents*
tab_contents = chrome::AddSelectedTabWithURL(
On 2012/10/05 14:29:49, Yury Semikhatsky wrote:
> Should we specify browser instance where to create the target?

There is not such term on the content level where the handler is defined.

https://chromiumcodereview.appspot.com/11033046/diff/5002/content/browser/deb...
File content/browser/debugger/devtools_http_handler_impl.cc (right):

https://chromiumcodereview.appspot.com/11033046/diff/5002/content/browser/deb...
content/browser/debugger/devtools_http_handler_impl.cc:421:
SendJson(connection_id, info, *dictionary.get());
On 2012/10/05 14:29:49, Yury Semikhatsky wrote:
> *dictionary.get() -> *dictionary

Done.

https://chromiumcodereview.appspot.com/11033046/diff/5002/content/browser/deb...
content/browser/debugger/devtools_http_handler_impl.cc:643:
base::StringPrintf("ws://%s/devtools/page/%s",
On 2012/10/05 14:29:49, Yury Semikhatsky wrote:
> wrong alignment

Done.

https://chromiumcodereview.appspot.com/11033046/diff/5002/content/shell/shell...
File content/shell/shell_devtools_delegate.h (right):

https://chromiumcodereview.appspot.com/11033046/diff/5002/content/shell/shell...
content/shell/shell_devtools_delegate.h:21: explicit
ShellDevToolsDelegate(BrowserContext* browser_context, int port);
On 2012/10/05 14:29:49, Yury Semikhatsky wrote:
> No need for explicit.

Done.

https://chromiumcodereview.appspot.com/11033046/diff/5002/content/shell/shell...
File content/shell/shell_devtools_delegate_android.cc (right):

https://chromiumcodereview.appspot.com/11033046/diff/5002/content/shell/shell...
content/shell/shell_devtools_delegate_android.cc:15: 
On 2012/10/05 14:29:49, Yury Semikhatsky wrote:
> Revert this line.

Done.

[yurys, 2012-10-05 14:37:00]

lgtm

[pfeldman, 2012-10-05 14:51:45]

Owners stamp request.

[jam, 2012-10-05 16:19:17]

lgtm

https://codereview.chromium.org/11033046/diff/12002/chrome/browser/debugger/b...
File chrome/browser/debugger/browser_list_tabcontents_provider.cc (right):

https://codereview.chromium.org/11033046/diff/12002/chrome/browser/debugger/b...
chrome/browser/debugger/browser_list_tabcontents_provider.cc:92:
GURL("about:blank"),
ditto

https://codereview.chromium.org/11033046/diff/12002/content/shell/shell_devto...
File content/shell/shell_devtools_delegate.cc (right):

https://codereview.chromium.org/11033046/diff/12002/content/shell/shell_devto...
content/shell/shell_devtools_delegate.cc:55: GURL("about:blank"),
nit: use kAboutBlankURL

[commit-bot: I haz the power, 2012-10-10 13:28:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pfeldman@chromium.org/11033046/12002

[commit-bot: I haz the power, 2012-10-10 13:31:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pfeldman@chromium.org/11033046/30003

[commit-bot: I haz the power, 2012-10-10 16:56:02]

Change committed as 161126