Sets ios_product_name and ios_breakpad flags for iOS.

Sets ios_product_name and ios_breakpad flags for iOS.

At the same time, modified the conditional logic to be more like mac's, i.e. incorporate the value of buildtype=="Official" to determine if it is a release build.

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160819

[pkl (ping after 24h if needed), 2012-10-05 09:29:38]

Stuart, I'm waiting for trybots to be fixed and do git-try again, but this
should be ready for your review.

Peter.

[stuartmorgan, 2012-10-05 12:08:44]

https://codereview.chromium.org/11033027/diff/2002/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11033027/diff/2002/build/common.gypi#newcode982
build/common.gypi:982: # Features unavailable on ios.
Remove this; it's not informative, and isn't actually correct for the block. (It
should come out of the internal tree too.)

https://codereview.chromium.org/11033027/diff/2002/build/common.gypi#newcode999
build/common.gypi:999: 'ios_breakpad%': 1,
This doesn't match what we do on Mac; as I mentioned before, fixing that should
be part of this CL.

[pkl (ping after 24h if needed), 2012-10-05 15:27:09]

PTAL

https://codereview.chromium.org/11033027/diff/2002/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11033027/diff/2002/build/common.gypi#newcode982
build/common.gypi:982: # Features unavailable on ios.
On 2012/10/05 12:08:45, stuartmorgan wrote:
> Remove this; it's not informative, and isn't actually correct for the block.
(It
> should come out of the internal tree too.)

Done.

https://codereview.chromium.org/11033027/diff/2002/build/common.gypi#newcode999
build/common.gypi:999: 'ios_breakpad%': 1,
On 2012/10/05 12:08:45, stuartmorgan wrote:
> This doesn't match what we do on Mac; as I mentioned before, fixing that
should
> be part of this CL.

I looked at the find_sdk.py invocation for Mac. It uses --verify which is
different from the non-upstream version. I preserved the logic used downstream.

[stuartmorgan, 2012-10-09 06:37:53]

LGTM

[commit-bot: I haz the power, 2012-10-09 08:55:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkl@chromium.org/11033027/8003

[commit-bot: I haz the power, 2012-10-09 10:50:33]

Change committed as 160819