[Contextual Search] Add support for tap on the selection.

content/browser/renderer_host/render_widget_host_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 
 #include <android/bitmap.h>
 
 #include "base/android/build_info.h"
 #include "base/basictypes.h"
@@ skipping 1625 matching lines @@
   if (overscroll_controller_)
     overscroll_controller_->OnGestureEventAck(event, ack_result);
 
   if (content_view_core_)
     content_view_core_->OnGestureEventAck(event, ack_result);
 }
 
 InputEventAckState RenderWidgetHostViewAndroid::FilterInputEvent(
     const blink::WebInputEvent& input_event) {
   if (selection_controller_) {
-    switch (input_event.type) {
-      case blink::WebInputEvent::GestureLongPress:
-        selection_controller_->OnLongPressEvent();
-        break;
-      case blink::WebInputEvent::GestureTap:
-        selection_controller_->OnTapEvent();
-        break;
-      default:
-        break;
+    const blink::WebGestureEvent& gesture_event =

[jdduke (slow), 2015/05/01 20:52:06]

Hmm, this cast isn't safe for non-gesture events. You can do:

if (selection_controller_ &&
    WebInputEvent::isGestureEventTye(input_event.type)) {
  const blink::WebGestureEvent& gesture_event =
  ...
}

[Donn Denman, 2015/05/01 22:46:03]

Done.

+        static_cast<const blink::WebGestureEvent&>(input_event);
+    gfx::PointF gesture_location(gesture_event.x, gesture_event.y);
+    if (input_event.type == blink::WebInputEvent::GestureLongPress) {
+      if (selection_controller_->WillHandleLongPressEvent(gesture_location)) {

[jdduke (slow), 2015/05/01 20:52:06]

Nit: No need for braces for this if conditional.

[Donn Denman, 2015/05/01 22:46:03]

Done.

+        return INPUT_EVENT_ACK_STATE_CONSUMED;
+      }
+    } else if (input_event.type == blink::WebInputEvent::GestureTap) {
+      if (selection_controller_->WillHandleTapEvent(gesture_location))
+        return INPUT_EVENT_ACK_STATE_CONSUMED;
     }
   }
 
   if (overscroll_controller_ &&
       blink::WebInputEvent::isGestureEventType(input_event.type) &&
       overscroll_controller_->WillHandleGestureEvent(
           static_cast<const blink::WebGestureEvent&>(input_event))) {
     return INPUT_EVENT_ACK_STATE_CONSUMED;
   }
 
@@ skipping 411 matching lines @@
   results->orientationAngle = display.RotationAsDegree();
   results->orientationType =
       RenderWidgetHostViewBase::GetOrientationTypeForMobile(display);
   gfx::DeviceDisplayInfo info;
   results->depth = info.GetBitsPerPixel();
   results->depthPerComponent = info.GetBitsPerComponent();
   results->isMonochrome = (results->depthPerComponent == 0);
 }
 
 } // namespace content