Add Android version name and code to gyp settings.

Add Android version name and code to gyp settings.

Add the default name and version code for Android, the version name
and code can be overriden by changing the GYP_DEFINES.

BUG=154236
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160522

[cjhopman, 2012-10-05 20:16:20]

https://codereview.chromium.org/11029061/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11029061/diff/1/build/common.gypi#newcode679
build/common.gypi:679: 'android_app_version_name%':
'<(android_app_version_name)',
Can't you just set the defaults here rather than setting them in 2 more levels
and then pulling them out?

[shashi, 2012-10-05 20:42:49]

https://codereview.chromium.org/11029061/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/11029061/diff/1/build/common.gypi#newcode679
build/common.gypi:679: 'android_app_version_name%':
'<(android_app_version_name)',
Done, the reason I did it was mostly for convention, if we may need this
variables for any conditional in upper level dictionaries then we can move it
back at that time.
On 2012/10/05 20:16:20, cjhopman wrote:
> Can't you just set the defaults here rather than setting them in 2 more levels
> and then pulling them out?

[cjhopman, 2012-10-05 20:45:21]

lgtm

[commit-bot: I haz the power, 2012-10-05 20:46:27]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[shashi, 2012-10-05 20:48:30]

+Isaac for committer approval.

[Isaac (away), 2012-10-05 21:16:55]

lgtm

[commit-bot: I haz the power, 2012-10-05 21:35:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/11029061/5001

[commit-bot: I haz the power, 2012-10-05 23:55:56]

Change committed as 160522