Issue 11029013: Explicit out-of-line destructor for AwContentsIoThreadClientImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11029013: Explicit out-of-line destructor for AwContentsIoThreadClientImpl. (Closed)

Created:
8 years, 2 months ago by John Knottenbelt

Modified:
8 years, 2 months ago

Reviewers:
mkosiba (inactive)

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Explicit out-of-line destructor for AwContentsIoThreadClientImpl. This is required by the clang style checker. See http://dev.chromium.org/developers/coding-style/chromium-style-checker-errors for more information. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159689

Patch Set 1 #

Patch Set 2 : Fix [chromium-style] error. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	android_webview/native/aw_contents_io_thread_client_impl.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

John Knottenbelt

This should help green the clang bot: http://build.chromium.org/p/chromium.fyi/builders/Android%20Clang%20%28dbg%29/builds/382/steps/compile/logs/stdio

8 years, 2 months ago (2012-10-02 11:09:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/11029013/1

8 years, 2 months ago (2012-10-02 12:39:58 UTC) #3

Change committed as 159689

Expand Messages | Collapse Messages