[Chromoting] Request the daemon to open a terminal once a connection has been accepted.

remoting/host/client_session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_CLIENT_SESSION_H_
 #define REMOTING_HOST_CLIENT_SESSION_H_
 
 #include <list>
 
 #include "base/memory/ref_counted.h"
@@ skipping 17 matching lines @@
 namespace base {
 class SingleThreadTaskRunner;
 }  // namespace base
 
 namespace remoting {
 
 class AudioEncoder;
 class AudioScheduler;
 struct ClientSessionTraits;
 class DesktopEnvironment;
+class DesktopEnvironmentFactory;
 class ScreenRecorder;
 class VideoEncoder;
 class VideoFrameCapturer;
 
 // A ClientSession keeps a reference to a connection to a client, and maintains
 // per-client state.
 class ClientSession
     : public base::RefCountedThreadSafe<ClientSession, ClientSessionTraits>,
       public protocol::HostStub,
       public protocol::ConnectionToClient::EventHandler,
@@ skipping 35 matching lines @@
 
    protected:
     virtual ~EventHandler() {}
   };
 
   ClientSession(EventHandler* event_handler,
                 scoped_refptr<base::SingleThreadTaskRunner> capture_task_runner,
                 scoped_refptr<base::SingleThreadTaskRunner> encode_task_runner,
                 scoped_refptr<base::SingleThreadTaskRunner> network_task_runner,
                 scoped_ptr<protocol::ConnectionToClient> connection,
-                scoped_ptr<DesktopEnvironment> desktop_environment,
+                DesktopEnvironmentFactory* desktop_environment_factory,

[Wez, 2012/10/17 22:04:24]

nit: Add a comment to clarify that |desktop_environment_factory_| is used only
in this ctor; otherwise it's not clear that passing an un-owned object to a
ref-counted one is safe!

On a related note, we should make sure our DesktopEnvironment[Factory]
implementations cope properly with the instances outliving the factory.

[alexeypa (please no reviews), 2012/10/17 22:46:56]

Done.

                 const base::TimeDelta& max_duration);
 
   // protocol::HostStub interface.
   virtual void NotifyClientDimensions(
       const protocol::ClientDimensions& dimensions) OVERRIDE;
   virtual void ControlVideo(
       const protocol::VideoControl& video_control) OVERRIDE;
 
   // protocol::ConnectionToClient::EventHandler interface.
   virtual void OnConnectionAuthenticated(
@@ skipping 127 matching lines @@
 };
 
 // Destroys |ClienSession| instances on the network thread.
 struct ClientSessionTraits {
   static void Destruct(const ClientSession* client);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_CLIENT_SESSION_H_