[Chromoting] Request the daemon to open a terminal once a connection has been accepted.

remoting/host/daemon_sender.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_DAEMON_SENDER_H_
 #define REMOTING_HOST_DAEMON_SENDER_H_
 
 #include "ipc/ipc_sender.h"
 
 namespace remoting {
 
 class DesktopEnvironment;
 
 class DaemonSender {

[Wez, 2012/10/13 00:47:15]

This class is called DaemonSender, but has two APIs that talk about "terminals",
both of which accept a DesktopEnvironment; the naming is really confusing,
especially without any comments to explain what DaemonSender is for, or what a
"terminal" is. ;)

Is the intent fundamentally that these calls just notify the daemon process of
DesktopEnvironment lifetimes, in which case more appropriate names might be
TerminalCreated and TerminalDestroyed (assuming that "terminal" refers to the
client"), or NotifyClientAttached/Detached, for example?

Or should these calls actually create the binding between the DesktopEnvironment
and the desktop session, so that you'd have e.g.
AttachTerminal(IpcDesktopEnvironment) and the IpcDesktopEnvironment would then
receive calls every time a new IPC channel to the desktop process is allocated?

[alexeypa (please no reviews), 2012/10/16 19:32:25]

This is the case. The class has been renamed to DesktopSessionConnector.

  public:
   DaemonSender() {}
   virtual ~DaemonSender() {}
 
-  // Registers |desktop_environment| with the daemon process causing a terminal
-  // to be associated with it.
-  virtual void RegisterDesktopEnvironment(
-      DesktopEnvironment* desktop_environment) = 0;
+  // Requests the daemon process to close terminal opened by OpenTerminal().
+  virtual void CloseTerminal(DesktopEnvironment* desktop_environment) = 0;
 
-  // Unregisters previously registered |desktop_environment|.
-  virtual void UnregisterDesktopEnvironment(
-      DesktopEnvironment* desktop_environment) = 0;
+  // Requests the daemon process to open a terminal and associates
+  // |desktop_environment| with it.
+  virtual void OpenTerminal(DesktopEnvironment* desktop_environment) = 0;

[Wez, 2012/10/13 00:47:15]

nit: Put this above CloseTerminal, since it's the first of the two that will be
called.

[alexeypa (please no reviews), 2012/10/16 19:32:25]

Done.

 
  private:
   DISALLOW_COPY_AND_ASSIGN(DaemonSender);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_DAEMON_SENDER_H_