Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2179)

Unified Diff: ui/base/resource/resource_bundle.h

Issue 11028064: Resize images for hi-dpi based on a custom PNG chunk added by GRIT r78, and roll GRIT r78 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/resource/resource_bundle.h
diff --git a/ui/base/resource/resource_bundle.h b/ui/base/resource/resource_bundle.h
index fcc07dbe81c8f42781d5dfbb337b044b710477e5..bd2ffa63106683e344ff9b424df79be0365b2276 100644
--- a/ui/base/resource/resource_bundle.h
+++ b/ui/base/resource/resource_bundle.h
@@ -282,14 +282,23 @@ class UI_EXPORT ResourceBundle {
// Initialize all the gfx::Font members if they haven't yet been initialized.
void LoadFontsIfNecessary();
- // Creates and returns a new SkBitmap given the data file to look in and the
- // |resource_id|. It's up to the caller to free the returned bitmap when
- // done.
- SkBitmap* LoadBitmap(const ResourceHandle& dll_inst, int resource_id) const;
-
- // Creates and returns a new SkBitmap for |resource_id| and |scale_factor|.
- // Returns NULL if the resource does not exist.
- SkBitmap* LoadBitmap(int resource_id, ScaleFactor scale_factor) const;
+ // Fills the |bitmap| given the data file to look in and the |resource_id|.
+ // Returns false if the resource does not exist.
+ //
+ // If the call succeeds and |scale_fallback| is not NULL, it is set to true
+ // if Chrome's custom csCl PNG chunk is present (indicating that GRIT fell
+ // back to the 100% image), false if not.
+ bool LoadBitmap(const ResourceHandle& data_handle,
+ int resource_id,
+ SkBitmap* bitmap,
+ bool* scale_fallback) const;
sail 2012/10/09 22:01:37 scale_fallback is not very descriptive. maybe did_
benrg 2012/10/10 02:18:13 How about fell_back_to_1x?
+
+ // Fills the |bitmap| given the |resource_id| and |scale_factor|.
+ // Returns false if the resource does not exist.
+ bool LoadBitmap(int resource_id,
+ ScaleFactor scale_factor,
+ SkBitmap* bitmap,
+ bool* scale_fallback) const;
// Returns an empty image for when a resource cannot be loaded. This is a
// bright red bitmap.

Powered by Google App Engine
This is Rietveld 408576698