tools/perf/perf_tools/scrolling_benchmark.py - Issue 11028021: cc: Improve frame/commit accounting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/perf_tools/scrolling_benchmark.py

Issue 11028021: cc: Improve frame/commit accounting (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address comments Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/perf_tools/scrolling_benchmark.py

diff --git a/tools/perf/perf_tools/scrolling_benchmark.py b/tools/perf/perf_tools/scrolling_benchmark.py

index 288efb129954ac50710b0f6515173b1a16cc37f9..347fff309532aa1255a975c407e70cf9f685f360 100644

--- a/tools/perf/perf_tools/scrolling_benchmark.py

+++ b/tools/perf/perf_tools/scrolling_benchmark.py

@@ -11,7 +11,7 @@ class DidNotScrollException(multi_page_benchmark.MeasurementFailure):

super(DidNotScrollException, self).__init__('Page did not scroll')

def CalcScrollResults(rendering_stats_deltas, results):

- num_frames_sent_to_screen = rendering_stats_deltas['numFramesSentToScreen']

+ num_frames_sent_to_screen = rendering_stats_deltas['rendererFrameCount']

mean_frame_time_seconds = (

rendering_stats_deltas['totalTimeInSeconds'] /

@@ -19,7 +19,7 @@ def CalcScrollResults(rendering_stats_deltas, results):

dropped_percent = (

rendering_stats_deltas['droppedFrameCount'] /

- float(num_frames_sent_to_screen))

+ float(rendering_stats_deltas['vsyncCount']))

results.Add('mean_frame_time', 'ms', round(mean_frame_time_seconds * 1000, 3))

results.Add('dropped_percent', '%', round(dropped_percent * 100, 1))

@@ -69,7 +69,7 @@ class ScrollingBenchmark(multi_page_benchmark.MultiPageBenchmark):

rendering_stats_deltas = tab.runtime.Evaluate(

'window.__renderingStatsDeltas')

- if not (rendering_stats_deltas['numFramesSentToScreen'] > 0):

+ if not (rendering_stats_deltas['rendererFrameCount'] > 0):

raise DidNotScrollException()

return rendering_stats_deltas