Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: content/browser/browser_plugin/test_browser_plugin_guest.cc

Issue 11028019: Browser plugin: Implement loadRedirect event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge conflicts. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/test_browser_plugin_guest.cc
diff --git a/content/browser/browser_plugin/test_browser_plugin_guest.cc b/content/browser/browser_plugin/test_browser_plugin_guest.cc
index 45d88f6a23f582802ecbf63e80babdec2c8676b2..e71deea73c0ef11975378d700e90ca3cc88d357a 100644
--- a/content/browser/browser_plugin/test_browser_plugin_guest.cc
+++ b/content/browser/browser_plugin/test_browser_plugin_guest.cc
@@ -30,9 +30,9 @@ TestBrowserPluginGuest::TestBrowserPluginGuest(
waiting_for_damage_buffer_with_size_(false),
last_damage_buffer_size_(gfx::Size()) {
// Listen to visibility changes so that a test can wait for these changes.
- registrar_.Add(this,
- NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED,
- Source<WebContents>(web_contents));
+ notification_registrar_.Add(this,
+ NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED,
+ Source<WebContents>(web_contents));
}
TestBrowserPluginGuest::~TestBrowserPluginGuest() {
@@ -53,11 +53,11 @@ void TestBrowserPluginGuest::Observe(int type,
if (was_hidden_message_loop_runner_)
was_hidden_message_loop_runner_->Quit();
}
- break;
+ return;
}
- default:
- NOTREACHED() << "Unexpected notification type: " << type;
}
+
+ BrowserPluginGuest::Observe(type, source, details);
}
void TestBrowserPluginGuest::SendMessageToEmbedder(IPC::Message* msg) {
« no previous file with comments | « content/browser/browser_plugin/test_browser_plugin_guest.h ('k') | content/common/browser_plugin_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698