Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 11026062: Screen Magnifier: Change keyboard shortcut from [ALT + Scroll] to [CTRL + ALT + Scroll] (Closed)

Created:
8 years, 2 months ago by yoshiki
Modified:
8 years, 2 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Screen Magnifier: Change keyboard shortcut from [ALT + Scroll] to [CTRL + ALT + Scroll] BUG=153961 TEST=manual TBR=sky@chromium.org # TRBing for a simple change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160353

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ash/magnifier/magnification_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yoshiki
zork: could you take a look?
8 years, 2 months ago (2012-10-05 07:40:13 UTC) #1
Zachary Kuznia
lgtm
8 years, 2 months ago (2012-10-05 07:51:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11026062/1
8 years, 2 months ago (2012-10-05 07:53:46 UTC) #3
commit-bot: I haz the power
Presubmit check for 11026062-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-05 07:53:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11026062/1
8 years, 2 months ago (2012-10-05 08:01:20 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-05 12:47:59 UTC) #6
Change committed as 160353

Powered by Google App Engine
This is Rietveld 408576698