Android: fix webview-in-android build config.

Android: fix webview-in-android build config.

The envsetup configuration for building WebView using the Android build
system has rotted. Rather than try to share the non_sdk_build_init code,
just repeat the (few) parts we need to avoid setting all the parts that
are inappropriate, and fix the parts that are wrong or outdated.

Also, upstream the common.gypi settings that are specific to the WebView
build.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160188

[Torne, 2012-10-04 14:20:56]

Hi Yaron,

This is the main set of fixes required to get the webview-in-android build
working again. Can you take a look?

[Yaron, 2012-10-04 16:04:42]

lgtm

https://codereview.chromium.org/11026038/diff/1/build/android/envsetup.sh
File build/android/envsetup.sh (right):

https://codereview.chromium.org/11026038/diff/1/build/android/envsetup.sh#new...
build/android/envsetup.sh:18: export ANDROID_SDK_BUILD=0
Hmm. So in theory, we plan to remove the SDK_BUILD flag as everything will be
SDK. I guess if you still need customizations at that point, we can make the
distinction as webview/non-webview. Sound reasonable?

[Torne, 2012-10-04 16:10:33]

I'd still like to kill more of the stuff in envsetup.sh in general, but for now
I just need the webview build to work :p

https://codereview.chromium.org/11026038/diff/1/build/android/envsetup.sh
File build/android/envsetup.sh (right):

https://codereview.chromium.org/11026038/diff/1/build/android/envsetup.sh#new...
build/android/envsetup.sh:18: export ANDROID_SDK_BUILD=0
On 2012/10/04 16:04:42, Yaron wrote:
> Hmm. So in theory, we plan to remove the SDK_BUILD flag as everything will be
> SDK. I guess if you still need customizations at that point, we can make the
> distinction as webview/non-webview. Sound reasonable?

Sure, we can just make the remaining things directly conditional on
CHROME_ANDROID_BUILD_WEBVIEW when you want to kill ANDROID_SDK_BUILD.

[commit-bot: I haz the power, 2012-10-04 16:11:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torne@chromium.org/11026038/1

[commit-bot: I haz the power, 2012-10-04 19:16:10]

Change committed as 160188

[Nico, 2012-12-07 20:41:41]

https://chromiumcodereview.appspot.com/11026038/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/11026038/diff/1/build/common.gypi#newc...
build/common.gypi:2817: '-Wno-error=sequence-point',
I happened to see this while reading common.gypi for something else.

It almost never makes sense to have warnings that are not errors. If you want to
fix them, file a bug to fix them, fix them, then turn on the warning as error.
If you don't want to fix them, turn off the warning -- nobody else will fix
them, and having a build that prints more than 0 warnings in the default
configuration just teaches people to ignore build warnings.

[Torne, 2012-12-11 11:37:51]

On 2012/12/07 20:41:41, Nico wrote:
> https://chromiumcodereview.appspot.com/11026038/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
>
https://chromiumcodereview.appspot.com/11026038/diff/1/build/common.gypi#newc...
> build/common.gypi:2817: '-Wno-error=sequence-point',
> I happened to see this while reading common.gypi for something else.
> 
> It almost never makes sense to have warnings that are not errors. If you want
to
> fix them, file a bug to fix them, fix them, then turn on the warning as error.
> If you don't want to fix them, turn off the warning -- nobody else will fix
> them, and having a build that prints more than 0 warnings in the default
> configuration just teaches people to ignore build warnings.

Yes, we should probably just disable these. Unfortunately the Android build
already has far, far more than 0 warnings in the default configuration even
without chromium's help :)

I'll doublecheck that we don't actually care about these things for now, and
just turn them off entirely. Thanks for the reminder, I had forgotten about
this.

[Torne, 2013-01-09 13:55:32]

On 2012/12/11 11:37:51, Torne wrote:
> On 2012/12/07 20:41:41, Nico wrote:
> > https://chromiumcodereview.appspot.com/11026038/diff/1/build/common.gypi
> > File build/common.gypi (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/11026038/diff/1/build/common.gypi#newc...
> > build/common.gypi:2817: '-Wno-error=sequence-point',
> > I happened to see this while reading common.gypi for something else.
> > 
> > It almost never makes sense to have warnings that are not errors. If you
want
> to
> > fix them, file a bug to fix them, fix them, then turn on the warning as
error.
> > If you don't want to fix them, turn off the warning -- nobody else will fix
> > them, and having a build that prints more than 0 warnings in the default
> > configuration just teaches people to ignore build warnings.
> 
> Yes, we should probably just disable these. Unfortunately the Android build
> already has far, far more than 0 warnings in the default configuration even
> without chromium's help :)
> 
> I'll doublecheck that we don't actually care about these things for now, and
> just turn them off entirely. Thanks for the reminder, I had forgotten about
> this.

Just as a followup: we've now disabled these warnings here.

[Nico, 2013-01-09 17:53:39]

On 2013/01/09 13:55:32, Torne wrote:
> On 2012/12/11 11:37:51, Torne wrote:
> > On 2012/12/07 20:41:41, Nico wrote:
> > > https://chromiumcodereview.appspot.com/11026038/diff/1/build/common.gypi
> > > File build/common.gypi (right):
> > > 
> > >
> >
>
https://chromiumcodereview.appspot.com/11026038/diff/1/build/common.gypi#newc...
> > > build/common.gypi:2817: '-Wno-error=sequence-point',
> > > I happened to see this while reading common.gypi for something else.
> > > 
> > > It almost never makes sense to have warnings that are not errors. If you
> want
> > to
> > > fix them, file a bug to fix them, fix them, then turn on the warning as
> error.
> > > If you don't want to fix them, turn off the warning -- nobody else will
fix
> > > them, and having a build that prints more than 0 warnings in the default
> > > configuration just teaches people to ignore build warnings.
> > 
> > Yes, we should probably just disable these. Unfortunately the Android build
> > already has far, far more than 0 warnings in the default configuration even
> > without chromium's help :)
> > 
> > I'll doublecheck that we don't actually care about these things for now, and
> > just turn them off entirely. Thanks for the reminder, I had forgotten about
> > this.
> 
> Just as a followup: we've now disabled these warnings here.

Nice, thanks! :-)