Add grit_whitelist for iOS.

Add grit_whitelist for iOS.

A large number of IDS resources are not used on iOS. This CL includes the used
ones via a grit whitelist file. The presubmit rule ensures that this file is 
ordered in ascending alphabetic order.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159879

[msarda, 2012-10-02 15:01:11]

Hi Stuart,
There are no owners for the directory "build". If this CL seems right to you,
please add the right chromium reviewer to the CL.
Thanks.

[stuartmorgan, 2012-10-02 16:16:56]

LGTM with nits.

https://chromiumcodereview.appspot.com/11026024/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/11026024/diff/1/build/common.gypi#newc...
build/common.gypi:1250: 'locales': [
This part isn't logically part of this CL, so should be removed. (and I'm not
sure it's even used locally, actually).

https://chromiumcodereview.appspot.com/11026024/diff/1/build/ios/PRESUBMIT.py
File build/ios/PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/11026024/diff/1/build/ios/PRESUBMIT.py...
build/ios/PRESUBMIT.py:35: 
Remove the extra blank line.

[stuartmorgan, 2012-10-02 16:18:09]

Tony, it looks like you've done a bunch with grit. Could you take a look at this
to get a fresh set of eyes on it?

[msarda, 2012-10-02 16:29:22]

https://chromiumcodereview.appspot.com/11026024/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/11026024/diff/1/build/common.gypi#newc...
build/common.gypi:1250: 'locales': [
On 2012/10/02 16:16:56, stuartmorgan wrote:
> This part isn't logically part of this CL, so should be removed. (and I'm not
> sure it's even used locally, actually).

This is not related (but we do need it though). I'll add it on a future CL.

https://chromiumcodereview.appspot.com/11026024/diff/1/build/ios/PRESUBMIT.py
File build/ios/PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/11026024/diff/1/build/ios/PRESUBMIT.py...
build/ios/PRESUBMIT.py:35: 
On 2012/10/02 16:16:56, stuartmorgan wrote:
> Remove the extra blank line.

Done.

[tony, 2012-10-02 18:41:15]

LGTM

https://chromiumcodereview.appspot.com/11026024/diff/5001/build/ios/PRESUBMIT.py
File build/ios/PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/11026024/diff/5001/build/ios/PRESUBMIT...
build/ios/PRESUBMIT.py:19: sorted = all(lines[i] <= lines[i+1] for i in
xrange(len(lines)-1))
Nit: Spaces around + and - (matches C++ style).

https://chromiumcodereview.appspot.com/11026024/diff/5001/build/ios/PRESUBMIT...
build/ios/PRESUBMIT.py:21: return [ output_api.PresubmitError(
Nit: No space after [ or before ].

[msarda, 2012-10-03 08:16:10]

Thanks for the review.

https://chromiumcodereview.appspot.com/11026024/diff/5001/build/ios/PRESUBMIT.py
File build/ios/PRESUBMIT.py (right):

https://chromiumcodereview.appspot.com/11026024/diff/5001/build/ios/PRESUBMIT...
build/ios/PRESUBMIT.py:19: sorted = all(lines[i] <= lines[i+1] for i in
xrange(len(lines)-1))
On 2012/10/02 18:41:15, tony wrote:
> Nit: Spaces around + and - (matches C++ style).

Done.

https://chromiumcodereview.appspot.com/11026024/diff/5001/build/ios/PRESUBMIT...
build/ios/PRESUBMIT.py:21: return [ output_api.PresubmitError(
On 2012/10/02 18:41:15, tony wrote:
> Nit: No space after [ or before ].

Done.

[commit-bot: I haz the power, 2012-10-03 08:16:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msarda@chromium.org/11026024/10001

[commit-bot: I haz the power, 2012-10-03 10:37:05]

Change committed as 159879