Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: vm/debugger.h

Issue 11026011: Add isolate event handler setup in order to be able to propagate isolate (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/code_generator.cc ('k') | vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/debugger.h
===================================================================
--- vm/debugger.h (revision 13083)
+++ vm/debugger.h (working copy)
@@ -212,6 +212,9 @@
kBreakpointReached = 1,
kBreakpointResolved = 2,
kExceptionThrown = 3,
+ kIsolateCreated = 4,
+ kIsolateShutdown = 5,
+ kIsolateInterrupted = 6,
};
struct DebuggerEvent {
EventType type;
@@ -219,6 +222,7 @@
DebuggerStackTrace* stack_trace;
SourceBreakpoint* breakpoint;
const Object* exception;
+ Isolate* isolate;
};
};
typedef void EventHandler(DebuggerEvent *event);
@@ -232,9 +236,6 @@
void NotifyCompilation(const Function& func);
- void SetEventHandler(EventHandler* handler);
- void SetBreakpointHandler(BreakpointHandler* handler);
-
RawFunction* ResolveFunction(const Library& library,
const String& class_name,
const String& function_name);
@@ -270,6 +271,10 @@
RawObject* GetCachedObject(intptr_t obj_id);
bool IsValidObjectId(intptr_t obj_id);
+ static void SetEventHandler(EventHandler* handler);
+ static void SetBreakpointHandler(BreakpointHandler* handler);
+ static void SignalIsolateEvent(EventType type);
hausner 2012/10/02 17:45:55 Maybe group this with the other SignalXXX function
siva 2012/10/02 18:09:31 Done.
+
// Utility functions.
static const char* QualifiedFunctionName(const Function& func);
@@ -327,8 +332,6 @@
Isolate* isolate_;
bool initialized_;
- BreakpointHandler* bp_handler_;
- EventHandler* event_handler_;
// ID number generator.
intptr_t next_id_;
@@ -355,6 +358,9 @@
intptr_t exc_pause_info_;
+ static BreakpointHandler* bp_handler_;
+ static EventHandler* event_handler_;
+
friend class SourceBreakpoint;
DISALLOW_COPY_AND_ASSIGN(Debugger);
};
« no previous file with comments | « vm/code_generator.cc ('k') | vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698