Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 11024010: Use correct location for Enter/LeaveNotify (Closed)

Created:
8 years, 2 months ago by oshima
Modified:
8 years, 2 months ago
Reviewers:
sadrul, Daniel Erat, sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org
Visibility:
Public.

Description

Use correct location for Enter/LeaveNotify This was giving wrong location (0,0) for ET_MOUSE_ENTERED/EXITED event. BUG=152501 TEST=manual: see bug for repro step. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159810

Patch Set 1 #

Total comments: 4

Patch Set 2 : add tests #

Patch Set 3 : adressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M ui/base/x/events_x.cc View 1 2 3 chunks +11 lines, -1 line 0 comments Download
M ui/base/x/events_x_unittest.cc View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
oshima
8 years, 2 months ago (2012-10-02 21:30:59 UTC) #1
sky
I'm not confident enough to say this is right. I'm rubber stamping, but could you ...
8 years, 2 months ago (2012-10-02 21:37:03 UTC) #2
sadrul
LGTM http://codereview.chromium.org/11024010/diff/1/ui/base/x/events_x.cc File ui/base/x/events_x.cc (right): http://codereview.chromium.org/11024010/diff/1/ui/base/x/events_x.cc#newcode873 ui/base/x/events_x.cc:873: } Update for Leave/Enter here too? http://codereview.chromium.org/11024010/diff/1/ui/base/x/events_x.cc#newcode905 ui/base/x/events_x.cc:905: ...
8 years, 2 months ago (2012-10-02 21:44:15 UTC) #3
Daniel Erat
lgtm
8 years, 2 months ago (2012-10-02 21:50:19 UTC) #4
oshima
http://codereview.chromium.org/11024010/diff/1/ui/base/x/events_x.cc File ui/base/x/events_x.cc (right): http://codereview.chromium.org/11024010/diff/1/ui/base/x/events_x.cc#newcode873 ui/base/x/events_x.cc:873: } On 2012/10/02 21:44:16, sadrul wrote: > Update for ...
8 years, 2 months ago (2012-10-02 21:58:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11024010/3002
8 years, 2 months ago (2012-10-02 21:59:58 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-03 00:23:41 UTC) #7
Change committed as 159810

Powered by Google App Engine
This is Rietveld 408576698