Issue 110223008: DevTools: Strip sourceURL comment from stylesheets before showing them in the editor.

Issue 110223008: DevTools: Strip sourceURL comment from stylesheets before showing them in the editor. (Closed)

Created:
7 years ago by vsevik

Modified:
7 years ago

Reviewers:
apavlov, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Strip sourceURL comment from stylesheets before showing them in the editor. This provides better UX when editing resources that are not mapped in workspace. R=apavlov, pfeldman_ooo Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164300

Patch Set 1 #

Total comments: 3

Patch Set 2 : Comments aprtly addressed #

Patch Set 3 : Made regex global #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -34 lines)			Patch
M	LayoutTests/inspector/styles/stylesheet-source-url-comment-expected.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/CSSStyleModel.js	View	1 2	7 chunks	+33 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/StylesSourceMapping.js	View		3 chunks	+12 lines, -28 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

apavlov

lgtm with nits https://chromiumcodereview.appspot.com/110223008/diff/1/Source/devtools/front_end/CSSStyleModel.js File Source/devtools/front_end/CSSStyleModel.js (right): https://chromiumcodereview.appspot.com/110223008/diff/1/Source/devtools/front_end/CSSStyleModel.js#newcode1419 Source/devtools/front_end/CSSStyleModel.js:1419: WebInspector.CSSStyleSheetHeader.sourceURLRegex = /\n[\040\t]*\/\*[#@][\040\t]sourceURL=[\040\t]*([^\s]*)[\040\t]*\*\/[\040\t]*$/m; Perhaps, \n -> ...

7 years ago (2013-12-20 10:06:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/110223008/20001

7 years ago (2013-12-23 15:23:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/110223008/120001

7 years ago (2013-12-23 16:09:56 UTC) #4

Message was sent while issue was closed.

Change committed as 164300

Expand Messages | Collapse Messages