lib/compiler/implementation/scanner/parser.dart - Issue 11021008: Added 'dynamic' keyword, so that 'Dynamic' can be deprecated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/scanner/parser.dart

Issue 11021008: Added 'dynamic' keyword, so that 'Dynamic' can be deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated tests status file with entered co19 issue. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « lib/compiler/implementation/scanner/keyword.dart ('k') | lib/compiler/implementation/scanner/scanner.dart » ('j') | tests/co19/co19-dart2dart.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/scanner/parser.dart

diff --git a/lib/compiler/implementation/scanner/parser.dart b/lib/compiler/implementation/scanner/parser.dart

index 33fa404e16ba65fb54a7878e28f2fee21e3df6d6..72fd63b483d0aa73011f218dc9b7a6b4b3d455c5 100644

--- a/lib/compiler/implementation/scanner/parser.dart

+++ b/lib/compiler/implementation/scanner/parser.dart

@@ -358,7 +358,11 @@ class Parser {

if (kind === KEYWORD_TOKEN) {

Keyword keyword = token.value;

String value = keyword.stringValue;

- return keyword.isPseudo || (value === 'Dynamic') || (value === 'void');

+ // TODO(aprelev@gmail.com): Remove deprecated Dynamic keyword support.

+ return keyword.isPseudo

+ || (value === 'dynamic')

+ || (value === 'Dynamic')

+ || (value === 'void');

}

return false;

}

« no previous file with comments | « lib/compiler/implementation/scanner/keyword.dart ('k') | lib/compiler/implementation/scanner/scanner.dart » ('j') | tests/co19/co19-dart2dart.status » ('J')