lib/compiler/implementation/dart_backend/placeholder_collector.dart - Issue 11021008: Added 'dynamic' keyword, so that 'Dynamic' can be deprecated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/dart_backend/placeholder_collector.dart

Issue 11021008: Added 'dynamic' keyword, so that 'Dynamic' can be deprecated. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated dart2dart test status file with co19 issue as well. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/compiler/implementation/dart_backend/placeholder_collector.dart

diff --git a/lib/compiler/implementation/dart_backend/placeholder_collector.dart b/lib/compiler/implementation/dart_backend/placeholder_collector.dart

index d6bbd20682073f6808ac2c9830fa579ad3ce3603..381b5da132b309018184d307446b06854324bca4 100644

--- a/lib/compiler/implementation/dart_backend/placeholder_collector.dart

+++ b/lib/compiler/implementation/dart_backend/placeholder_collector.dart

@@ -422,7 +422,8 @@ class PlaceholderCollector extends Visitor {

static bool isDynamicType(TypeAnnotation typeAnnotation) {

if (!isPlainTypeName(typeAnnotation)) return false;

String name = typeAnnotation.typeName.asIdentifier().source.slowToString();

- return name == 'Dynamic';

+ // TODO(aprelev@gmail.com): Removed deprecated Dynamic keyword support.

+ return name == 'Dynamic' || name == 'dynamic';

}

visitTypeAnnotation(TypeAnnotation node) {

« no previous file with comments | « no previous file | lib/compiler/implementation/resolver.dart » ('j') | no next file with comments »