Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11018013: add a new, blank version of content settings so that a new UI may be prototyped (Closed)

Created:
8 years, 2 months ago by Evan Stade
Modified:
8 years, 2 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

add a new, blank version of content settings so that a new UI may be prototyped behind a flag BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162375

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -1 line) Patch
M chrome/browser/resources/options/content_settings.js View 1 2 chunks +4 lines, -0 lines 0 comments Download
A chrome/browser/resources/options/content_settings2.html View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/resources/options/content_settings2.js View 1 chunk +88 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options.html View 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Evan Stade
8 years, 2 months ago (2012-10-01 14:57:10 UTC) #1
markusheintz_
LGTM! Thanks a lot for this CL!!
8 years, 2 months ago (2012-10-16 14:19:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/11018013/1
8 years, 2 months ago (2012-10-16 18:41:42 UTC) #3
commit-bot: I haz the power
Presubmit check for 11018013-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-16 18:42:17 UTC) #4
Evan Stade
+thestig for owners stamp on chrome/
8 years, 2 months ago (2012-10-16 21:16:27 UTC) #5
Lei Zhang
lgtm
8 years, 2 months ago (2012-10-16 21:21:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/11018013/1
8 years, 2 months ago (2012-10-16 21:25:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/11018013/11001
8 years, 2 months ago (2012-10-17 03:03:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/11018013/11001
8 years, 2 months ago (2012-10-17 11:13:26 UTC) #9
commit-bot: I haz the power
8 years, 2 months ago (2012-10-17 13:13:35 UTC) #10 
Change committed as 162375

Powered by Google App Engine
This is Rietveld 408576698