Don't intercept POST navigation in android_webview.

Don't intercept POST navigation in android_webview.

This excludes POST navigations from navigation intercepting.
This also adds a test case which ensures that subframe navigations
are not intercepted.

BUG=155250
android_webview-specific change, ran through trybots.
NOTRY=true


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161601

[mkosiba (inactive), 2012-10-11 13:43:40]

PTAL

[benm (inactive), 2012-10-11 14:05:30]

https://codereview.chromium.org/11017075/diff/1/android_webview/browser/rende...
File
android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/11017075/diff/1/android_webview/browser/rende...
android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc:99:
request->method() != "POST") {
will it always be CAPS? is there a const we can use somewhere?

https://codereview.chromium.org/11017075/diff/1/android_webview/javatests/src...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwShouldIgnoreNavigationTest.java
(right):

https://codereview.chromium.org/11017075/diff/1/android_webview/javatests/src...
android_webview/javatests/src/org/chromium/android_webview/test/AwShouldIgnoreNavigationTest.java:539:
// There reason POST requests are excluded is BUG 155250.
sp The

[mkosiba (inactive), 2012-10-11 14:22:53]

https://codereview.chromium.org/11017075/diff/1/android_webview/browser/rende...
File
android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
(right):

https://codereview.chromium.org/11017075/diff/1/android_webview/browser/rende...
android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc:99:
request->method() != "POST") {
On 2012/10/11 14:05:30, benm wrote:
> will it always be CAPS? is there a const we can use somewhere?

apparently... these doesn't seem to be a constant defined or anything, this is
how the rest of the codebase perfroms this check.

https://codereview.chromium.org/11017075/diff/1/android_webview/javatests/src...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwShouldIgnoreNavigationTest.java
(right):

https://codereview.chromium.org/11017075/diff/1/android_webview/javatests/src...
android_webview/javatests/src/org/chromium/android_webview/test/AwShouldIgnoreNavigationTest.java:539:
// There reason POST requests are excluded is BUG 155250.
On 2012/10/11 14:05:30, benm wrote:
> sp The

Done.

[benm (inactive), 2012-10-11 14:28:41]

lgtm

[joth, 2012-10-11 22:12:10]

lgtm

[commit-bot: I haz the power, 2012-10-12 17:02:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/11017075/10001

[commit-bot: I haz the power, 2012-10-12 17:02:43]

Change committed as 161601