Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 11017045: [Mac] Enumerate webcam devices on the main thread. (Closed)

Created:
8 years, 2 months ago by Scott Hess - ex-Googler
Modified:
8 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

[Mac] Enumerate webcam devices on the main thread. The associated bug is about a crash in code which is only loaded due to +deviceNames, though the crash does not have any such code on the stack. If that call were not thread-safe, then possibly using it on a different thread breaks assumptions about where things are allocated and released. BUG=139164 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161024

Patch Set 1 #

Total comments: 1

Patch Set 2 : Whitespace change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M media/video/capture/mac/video_capture_device_qtkit_mac.mm View 1 1 chunk +15 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Scott Hess - ex-Googler
This one is also easy to put on the main thread. WDYT? This would foul ...
8 years, 2 months ago (2012-10-09 23:42:24 UTC) #1
wjia(left Chromium)
lgtm
8 years, 2 months ago (2012-10-09 23:49:41 UTC) #2
sail
LGTM! https://codereview.chromium.org/11017045/diff/1/media/video/capture/mac/video_capture_device_qtkit_mac.mm File media/video/capture/mac/video_capture_device_qtkit_mac.mm (right): https://codereview.chromium.org/11017045/diff/1/media/video/capture/mac/video_capture_device_qtkit_mac.mm#newcode28 media/video/capture/mac/video_capture_device_qtkit_mac.mm:28: + (NSDictionary *)deviceNames { no space before *
8 years, 2 months ago (2012-10-09 23:53:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/11017045/5001
8 years, 2 months ago (2012-10-09 23:58:20 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-10 02:45:27 UTC) #5
Change committed as 161024

Powered by Google App Engine
This is Rietveld 408576698