Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11017016: Add support for building apk in release (Closed)

Created:
8 years, 2 months ago by cjhopman
Modified:
8 years, 2 months ago
Reviewers:
Yaron, Torne, nilesh
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@apk_combine
Visibility:
Public.

Description

Add support for building apk in release Until now, even in a Release configuration, apks were built in debug. Now, they will be built in the correct configuration. BUG= TBR=torne Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160913

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M android_webview/java/AndroidManifest.xml View 1 1 chunk +1 line, -2 lines 0 comments Download
M build/android/ant/chromium-apk.xml View 1 1 chunk +10 lines, -1 line 0 comments Download
M build/java_apk.gypi View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M chrome/android/testshell/java/AndroidManifest.xml View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/android/java/AndroidManifest.xml View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cjhopman
8 years, 2 months ago (2012-10-08 18:40:45 UTC) #1
nilesh
LGTM http://codereview.chromium.org/11017016/diff/2001/build/java_apk.gypi File build/java_apk.gypi (right): http://codereview.chromium.org/11017016/diff/2001/build/java_apk.gypi#newcode108 build/java_apk.gypi:108: extra line?
8 years, 2 months ago (2012-10-08 21:56:13 UTC) #2
Yaron
lgtm http://codereview.chromium.org/11017016/diff/2001/build/java_apk.gypi File build/java_apk.gypi (right): http://codereview.chromium.org/11017016/diff/2001/build/java_apk.gypi#newcode80 build/java_apk.gypi:80: # TODO(cjhopman): Apks are built with a -debug ...
8 years, 2 months ago (2012-10-08 21:58:36 UTC) #3
cjhopman
http://codereview.chromium.org/11017016/diff/2001/build/java_apk.gypi File build/java_apk.gypi (right): http://codereview.chromium.org/11017016/diff/2001/build/java_apk.gypi#newcode109 build/java_apk.gypi:109: '<(CONFIGURATION_NAME)', On 2012/10/08 21:58:36, Yaron wrote: > Can you ...
8 years, 2 months ago (2012-10-09 18:18:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/11017016/8001
8 years, 2 months ago (2012-10-09 18:18:30 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-10-09 20:17:57 UTC) #6 
Change committed as 160913

Powered by Google App Engine
This is Rietveld 408576698