Don't show downloads from web intents picker in shelf

Don't show downloads from web intents picker in shelf

This CL adds a new attribute to DownloadItem that can be used to suppress the download shelf.

This attribute is set the by web intent picker to hide extension downloads.

BUG=152010
TBR=sky@chromium.org
TEST=Go to http://webintents.org. Click share. Click "Add to Chrome". Verify that the download shelf is not shown.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161040

[sail, 2012-10-02 23:09:48]

This was originally this CL:
https://codereview.chromium.org/10980002/

Now it only contains the download specific code.

[Avi (use Gerrit), 2012-10-02 23:12:12]

My disagreement stands. This adds an interface to content code that isn't used
by content, but by chrome. This is clearly not something that belongs in
content.

[sail, 2012-10-02 23:15:15]

On 2012/10/02 23:12:12, Avi wrote:
> My disagreement stands. This adds an interface to content code that isn't used
> by content, but by chrome. This is clearly not something that belongs in
> content.

Sounds good. I'll wait for feedback from rdsmith and asanka on how to proceed.
In the meantime, this CL is no longer blocking the web intents folks which is
good news!

[Randy Smith (Not in Mondays), 2012-10-08 17:53:48]

On 2012/10/02 23:15:15, sail wrote:
> On 2012/10/02 23:12:12, Avi wrote:
> > My disagreement stands. This adds an interface to content code that isn't
used
> > by content, but by chrome. This is clearly not something that belongs in
> > content.
> 
> Sounds good. I'll wait for feedback from rdsmith and asanka on how to proceed.
> In the meantime, this CL is no longer blocking the web intents folks which is
> good news!

I believe you now have that feedback and are unblocked, but please let me know
if that's not right.

[sail, 2012-10-09 19:31:35]

Removed changes to content/*.
Please take another look.

[Randy Smith (Not in Mondays), 2012-10-09 19:36:05]

Quick bit of confusion.

http://codereview.chromium.org/11016022/diff/5001/chrome/browser/download/dow...
File chrome/browser/download/download_browsertest.cc (right):

http://codereview.chromium.org/11016022/diff/5001/chrome/browser/download/dow...
chrome/browser/download/download_browsertest.cc:211:
item->SetShouldShowInShelf(item, false);
How does this work?  Or is it left over from a previous patchset?  (This method
doesn't exist on the DownloadItem in my checkout, and you're not doing any
changes in content.)

[sail, 2012-10-09 19:46:13]

https://codereview.chromium.org/11016022/diff/5001/chrome/browser/download/do...
File chrome/browser/download/download_browsertest.cc (right):

https://codereview.chromium.org/11016022/diff/5001/chrome/browser/download/do...
chrome/browser/download/download_browsertest.cc:211:
item->SetShouldShowInShelf(item, false);
On 2012/10/09 19:36:06, rdsmith wrote:
> How does this work?  Or is it left over from a previous patchset?  (This
method
> doesn't exist on the DownloadItem in my checkout, and you're not doing any
> changes in content.)

Done.
argh, merge conflict. Fixed.

[Randy Smith (Not in Mondays), 2012-10-09 20:09:00]

Happy to go with Asanka's review.  I don't think download_util.h is the best
place, but there may not be a better one in the current config.  

Removing myself from reviewer list.

[asanka, 2012-10-09 20:22:36]

LGTM. Thanks!

[commit-bot: I haz the power, 2012-10-09 20:31:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/11016022/7002

[commit-bot: I haz the power, 2012-10-09 20:31:14]

Presubmit check for 11016022-7002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/intents
    chrome/browser/ui

Presubmit checks took 4.1s to calculate.

[sail, 2012-10-09 20:34:54]

+gbillock for intents/*

[Greg Billock, 2012-10-09 22:31:21]

On 2012/10/09 20:34:54, sail wrote:
> +gbillock for intents/*

lgtm

[commit-bot: I haz the power, 2012-10-09 22:35:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/11016022/7002

[commit-bot: I haz the power, 2012-10-09 22:35:25]

Presubmit check for 11016022-7002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui

Presubmit checks took 1.3s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[sail, 2012-10-09 23:11:32]

sky reviewed this in a different CL. TBRing him.

[commit-bot: I haz the power, 2012-10-09 23:12:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/11016022/7002

[commit-bot: I haz the power, 2012-10-09 23:12:23]

Presubmit check for 11016022-7002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui

Presubmit checks took 1.3s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-10-09 23:57:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/11016022/7002

[commit-bot: I haz the power, 2012-10-09 23:58:01]

Presubmit check for 11016022-7002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui

Presubmit checks took 1.0s to calculate.

[commit-bot: I haz the power, 2012-10-09 23:58:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/11016022/7002

[commit-bot: I haz the power, 2012-10-10 00:51:50]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-10-10 02:16:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/11016022/18005

[commit-bot: I haz the power, 2012-10-10 04:28:14]

Change committed as 161040