Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 11016002: Kill adb server each buildbot run (Closed)

Created:
8 years, 2 months ago by Isaac (away)
Modified:
8 years, 2 months ago
Reviewers:
Yaron
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Kill adb server each buildbot run - We think this will alleviate the adb issues we had on the main waterfall tester earlier today. Our downstream testers do this each build already. BUG=152944 R=yaron Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159411

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/android/buildbot/buildbot_functions.sh View 1 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Isaac (away)
8 years, 2 months ago (2012-09-28 23:23:24 UTC) #1
Yaron
https://codereview.chromium.org/11016002/diff/1/build/android/buildbot/buildbot_functions.sh File build/android/buildbot/buildbot_functions.sh (right): https://codereview.chromium.org/11016002/diff/1/build/android/buildbot/buildbot_functions.sh#newcode76 build/android/buildbot/buildbot_functions.sh:76: ||||||| merged common ancestors I think you want to ...
8 years, 2 months ago (2012-09-29 00:54:12 UTC) #2
Isaac (away)
now serving the new and improved patchset 2 https://codereview.chromium.org/11016002/diff/1/build/android/buildbot/buildbot_functions.sh File build/android/buildbot/buildbot_functions.sh (right): https://codereview.chromium.org/11016002/diff/1/build/android/buildbot/buildbot_functions.sh#newcode76 build/android/buildbot/buildbot_functions.sh:76: ||||||| ...
8 years, 2 months ago (2012-09-29 01:09:03 UTC) #3
Yaron
https://codereview.chromium.org/11016002/diff/5001/build/android/buildbot/buildbot_functions.sh File build/android/buildbot/buildbot_functions.sh (right): https://codereview.chromium.org/11016002/diff/5001/build/android/buildbot/buildbot_functions.sh#newcode71 build/android/buildbot/buildbot_functions.sh:71: adb kill-server This is run for builders too, isn't? ...
8 years, 2 months ago (2012-09-29 01:12:35 UTC) #4
Isaac (away)
yes... but it doesn't matter and we don't have a top level 'run these tests ...
8 years, 2 months ago (2012-09-29 01:16:32 UTC) #5
Yaron
lgtm
8 years, 2 months ago (2012-09-29 01:36:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/11016002/5001
8 years, 2 months ago (2012-09-29 10:46:33 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-09-29 14:22:56 UTC) #8
Change committed as 159411

Powered by Google App Engine
This is Rietveld 408576698