Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 11014015: implement AudioManagerMac::GetPreferredLowLatencyOutputStreamParameters( (Closed)

Created:
8 years, 2 months ago by no longer working on chromium
Modified:
8 years, 2 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use clients' preferred buffer size when the sample rates match and it is a number smaller than 2047. BUG=152780 TEST=apprtc.appspot.com/?debug=loopback, no choppy audio Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159666

Patch Set 1 : #

Total comments: 2

Patch Set 2 : address Dale's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M media/audio/mac/audio_manager_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 1 3 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
no longer working on chromium
Dale, could you please take a quick review?
8 years, 2 months ago (2012-10-01 11:01:32 UTC) #1
DaleCurtis
lgtm % nits. https://codereview.chromium.org/11014015/diff/2001/media/audio/mac/audio_manager_mac.cc File media/audio/mac/audio_manager_mac.cc (right): https://codereview.chromium.org/11014015/diff/2001/media/audio/mac/audio_manager_mac.cc#newcode30 media/audio/mac/audio_manager_mac.cc:30: static const int kMaxBufferSize = 2047; ...
8 years, 2 months ago (2012-10-01 17:37:36 UTC) #2
no longer working on chromium
http://codereview.chromium.org/11014015/diff/2001/media/audio/mac/audio_manager_mac.cc File media/audio/mac/audio_manager_mac.cc (right): http://codereview.chromium.org/11014015/diff/2001/media/audio/mac/audio_manager_mac.cc#newcode30 media/audio/mac/audio_manager_mac.cc:30: static const int kMaxBufferSize = 2047; On 2012/10/01 17:37:36, ...
8 years, 2 months ago (2012-10-02 08:06:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/11014015/7001
8 years, 2 months ago (2012-10-02 08:06:35 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-02 09:51:39 UTC) #5
Change committed as 159666

Powered by Google App Engine
This is Rietveld 408576698