Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 11014014: Implement hyphenation for DumpRenderTree. (Closed)

Created:
8 years, 2 months ago by Hironori Bono
Modified:
7 years, 11 months ago
Reviewers:
tony, Nico
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Implement hyphenation for DumpRenderTree. This change implements the platform functions added by my WebKit change r124434 <http://trac.webkit.org/changeset/124434>; for DumpRenderTree. It is a simplified version of my r146964 <http://crrev.com/146964>;. BUG=47083 TEST=hyphen*.html Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160337

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -1 line) Patch
M webkit/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/support/test_webkit_platform_support.h View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 2 4 chunks +80 lines, -1 line 2 comments Download
M webkit/support/webkit_support.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Hironori Bono
Greetings Tony, Thank you for your review in advance. As listed in the trybot results, ...
8 years, 2 months ago (2012-10-02 09:13:47 UTC) #1
tony
LGTM. FOr the layout tests, I would, 1) Mark the layout tests as as failing ...
8 years, 2 months ago (2012-10-02 18:18:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/11014014/17003
8 years, 2 months ago (2012-10-03 09:05:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/11014014/17003
8 years, 2 months ago (2012-10-04 01:51:41 UTC) #4
commit-bot: I haz the power
Change committed as 160044
8 years, 2 months ago (2012-10-04 01:53:05 UTC) #5
Nico
7 years, 11 months ago (2013-01-20 04:45:11 UTC) #6
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/11014014/diff/6004/webkit/support/test...
File webkit/support/test_webkit_platform_support.cc (right):

https://chromiumcodereview.appspot.com/11014014/diff/6004/webkit/support/test...
webkit/support/test_webkit_platform_support.cc:518: if
(!PathService::Get(base::DIR_SOURCE_ROOT, &path))
This is possibly not correct on linux for standalone webkit builds, see
https://code.google.com/p/chromium/issues/detail?id=171146

https://chromiumcodereview.appspot.com/11014014/diff/6004/webkit/support/test...
webkit/support/test_webkit_platform_support.cc:524: if
(!file_util::ReadFileToString(path, &dictionary))
Relatedly, should this be DCHECK()ed?

Powered by Google App Engine
This is Rietveld 408576698