Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 11013043: beginSmoothScroll should send wheel ticks at constant velocity. (Closed)

Created:
8 years, 2 months ago by nduca
Modified:
8 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, DaveMoore
Visibility:
Public.

Description

beginSmoothScroll should send wheel ticks at constant velocity. There are two fixes here: 1. Compute the wheel tick amount based on time elapsed rather than our post message rate. 2. Try to trigger a new forward when needed on the inputAck, instead of using postTask. This helps when the main thread is busy doing swaps, which happens on OSX. BUG=149408 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161038

Patch Set 1 #

Patch Set 2 : git try #

Total comments: 6

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -9 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 4 chunks +52 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 2 4 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nduca
This (I think) should make the scrolls a lot smoother in our benchmarks.
8 years, 2 months ago (2012-10-06 02:15:26 UTC) #1
piman
LGTM+nits At a high level, if this functionality is going to continue to grow, it ...
8 years, 2 months ago (2012-10-06 06:18:57 UTC) #2
nduca
> At a high level, if this functionality is going to continue to grow, it ...
8 years, 2 months ago (2012-10-10 02:12:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/11013043/11001
8 years, 2 months ago (2012-10-10 02:18:31 UTC) #4
commit-bot: I haz the power
8 years, 2 months ago (2012-10-10 04:19:20 UTC) #5
Change committed as 161038

Powered by Google App Engine
This is Rietveld 408576698