Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 11013040: Add override for obfuscate target to support Proguard. (Closed)

Created:
8 years, 2 months ago by shashi
Modified:
8 years, 2 months ago
Reviewers:
cjhopman, nilesh
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Add override for obfuscate target to support Proguard. Ant builds do not support Proguard because the default obfuscate target does not support using custom classpaths for jars. Add javac.custom.classpath to the obfuscate target. BUG=149214 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160917

Patch Set 1 : sdk-tools #

Patch Set 2 : changes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
M build/android/ant/sdk-targets.xml View 1 1 chunk +80 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
shashi
8 years, 2 months ago (2012-10-05 22:35:37 UTC) #1
shashi
https://chromiumcodereview.appspot.com/11013040/diff/1/build/android/ant/sdk-targets.xml File build/android/ant/sdk-targets.xml (right): https://chromiumcodereview.appspot.com/11013040/diff/1/build/android/ant/sdk-targets.xml#newcode207 build/android/ant/sdk-targets.xml:207: <path refid="javac.custom.classpath"/> Only customization is here, I tried overriding ...
8 years, 2 months ago (2012-10-05 22:41:42 UTC) #2
shashi
https://codereview.chromium.org/11013040/diff/9001/build/android/ant/sdk-targets.xml File build/android/ant/sdk-targets.xml (right): https://codereview.chromium.org/11013040/diff/9001/build/android/ant/sdk-targets.xml#newcode207 build/android/ant/sdk-targets.xml:207: <path refid="javac.custom.classpath"/> Relevant change here.
8 years, 2 months ago (2012-10-08 18:50:37 UTC) #3
cjhopman
lgtm
8 years, 2 months ago (2012-10-09 18:13:53 UTC) #4
nilesh
On 2012/10/09 18:13:53, cjhopman wrote: > lgtm Rubberstamp LGTM
8 years, 2 months ago (2012-10-09 18:30:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/11013040/9001
8 years, 2 months ago (2012-10-09 18:32:12 UTC) #6
commit-bot: I haz the power
8 years, 2 months ago (2012-10-09 20:53:15 UTC) #7
Change committed as 160917

Powered by Google App Engine
This is Rietveld 408576698