chrome/browser/resources/shared/js/cr/ui/context_menu_handler.js - Issue 11013021: Basic keyboard access for recently_closed menu on NTP (re-work).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/shared/js/cr/ui/context_menu_handler.js

Issue 11013021: Basic keyboard access for recently_closed menu on NTP (re-work). (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase to current version. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/ntp4/recently_closed.js ('K') | « chrome/browser/resources/ntp4/recently_closed.js ('k') | chrome/browser/resources/shared/js/cr/ui/menu.js » ('j') | chrome/browser/resources/shared/js/cr/ui/menu_button.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/shared/js/cr/ui/context_menu_handler.js

diff --git a/chrome/browser/resources/shared/js/cr/ui/context_menu_handler.js b/chrome/browser/resources/shared/js/cr/ui/context_menu_handler.js

index e0af9189b09dbaf28e9811feccc7c91966c8ca25..f075d1fef88beb5aed0b794a7c3bc0ef7f99f075 100644

--- a/chrome/browser/resources/shared/js/cr/ui/context_menu_handler.js

+++ b/chrome/browser/resources/shared/js/cr/ui/context_menu_handler.js

@@ -39,7 +39,7 @@ cr.define('cr.ui', function() {

var doc = menu.ownerDocument;

doc.addEventListener('keydown', this, true);

doc.addEventListener('mousedown', this, true);

- doc.addEventListener('blur', this, true);

+ doc.addEventListener('focus', this, true);

doc.defaultView.addEventListener('resize', this);

menu.addEventListener('contextmenu', this);

menu.addEventListener('activate', this);

@@ -59,7 +59,7 @@ cr.define('cr.ui', function() {

var doc = menu.ownerDocument;

doc.removeEventListener('keydown', this, true);

doc.removeEventListener('mousedown', this, true);

- doc.removeEventListener('blur', this, true);

+ doc.removeEventListener('focus', this, true);

doc.defaultView.removeEventListener('resize', this);

menu.removeEventListener('contextmenu', this);

menu.removeEventListener('activate', this);

@@ -146,8 +146,12 @@ cr.define('cr.ui', function() {

}

break;

+ case 'focus':

+ if (!this.menu.contains(e.target))

+ this.hideMenu();

+ break;

case 'activate':

- case 'blur':

case 'resize':

this.hideMenu();

break;