Basic keyboard access for recently_closed menu on NTP (re-work).

chrome/browser/resources/ntp4/recently_closed.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview The recently closed menu: button, model data, and menu.
  */
 
 cr.define('ntp', function() {
   'use strict';
@@ skipping 72 matching lines @@
         a.href = '';
         a.classList.add('recent-window');
         a.textContent = formatTabsText(data.tabs.length);
         a.title = data.tabs.map(function(tab) { return tab.title; }).join('\n');
       } else {
         a.href = data.url;
         a.style.backgroundImage = 'url(chrome://favicon/' + data.url + ')';
         a.textContent = data.title;
       }
 
-      function onClick(e) {
+      function onActivated(e) {
         ntp.logTimeToClick('RecentlyClosed');
         chrome.send('recordAppLaunchByURL',
                     [encodeURIComponent(data.url),
                      ntp.APP_LAUNCH.NTP_RECENTLY_CLOSED]);
         var index = Array.prototype.indexOf.call(a.parentNode.children, a);
-        chrome.send('reopenTab', [data.sessionId, index,
-            e.button, e.altKey, e.ctrlKey, e.metaKey, e.shiftKey]);
+        var orig = e.originalEvent;
+        var params = [data.sessionId,
+                      index,
+                      orig.type == 'click' ? orig.button : 0,
+                      orig.altKey,
+                      orig.ctrlKey,
+                      orig.metaKey,
+                      orig.shiftKey];
+        chrome.send('reopenTab', params);
+
         // We are likely deleted by this point!
-
+        e.stopPropagation();

[Dan Beam, 2013/03/14 21:22:01]

aboxhall@: ^ why did you add this?

         e.preventDefault();
       }
-      a.addEventListener('click', onClick);
+      a.addEventListener('activate', onActivated);
 
       this.menu.appendChild(a);
       cr.ui.decorate(a, MenuItem);
     },
   };
 
   return {
     RecentMenuButton: RecentMenuButton,
   };
 });