Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 11012003: Clean up Android default command line flags. (Closed)

Created:
8 years, 2 months ago by aelias_OOO_until_Jul13
Modified:
8 years, 2 months ago
Reviewers:
Yaron, Jói
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, epenner
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Clean up Android default command line flags. - New flags --enable-touch-events, --enable-pinch, --enable-gesture-tap-highlight. - Remove Pepper-related flags. If we add support for Pepper in the future it's better to start from a clean slate anyway. - Remove --graphics-mode flag; currently only one mode works, and we won't be using it for changing modes in the future. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159561

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -97 lines) Patch
M content/browser/android/android_browser_process.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/android/content_startup_flags.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/android/content_startup_flags.cc View 5 chunks +12 lines, -74 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/AndroidBrowserProcess.java View 1 chunk +2 lines, -6 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
aelias_OOO_until_Jul13
I went into the Android default flags file to add --enable-gesture-tap-highlight, and took the opportunity ...
8 years, 2 months ago (2012-09-29 00:41:50 UTC) #1
Jói
LGTM for content/public (other bits too, but Yaron is a better reviewer for those).
8 years, 2 months ago (2012-10-01 10:32:41 UTC) #2
Yaron
lgtm
8 years, 2 months ago (2012-10-01 16:04:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/11012003/1
8 years, 2 months ago (2012-10-01 16:12:13 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s) compile
8 years, 2 months ago (2012-10-01 16:16:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/11012003/6003
8 years, 2 months ago (2012-10-01 16:54:33 UTC) #6
commit-bot: I haz the power
Retried try job too often for step(s) compile
8 years, 2 months ago (2012-10-01 17:00:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/11012003/6003
8 years, 2 months ago (2012-10-01 18:36:46 UTC) #8
commit-bot: I haz the power
8 years, 2 months ago (2012-10-01 21:26:43 UTC) #9
Change committed as 159561

Powered by Google App Engine
This is Rietveld 408576698