Set DragDropTracker's capture window's size to zero, otherwise, it gets

Set DragDropTracker's capture window's size to zero, otherwise, it gets
properties of normal windows such as shadows and also affects the launcher
opacity (since the current size makes it overlap the launcher).

BUG=147407
TEST=manual: starting drag/drop should not trigger wierd visual effects like
shadow animations and also should not affect the opacity of the launcher.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159635

[varunjain, 2012-09-29 06:27:04]

sky for OWNERS
mazda for DragDropTracker

[mazda, 2012-09-29 06:47:56]

https://codereview.chromium.org/11009010/diff/1/ash/drag_drop/drag_drop_track...
File ash/drag_drop/drag_drop_tracker.cc (left):

https://codereview.chromium.org/11009010/diff/1/ash/drag_drop/drag_drop_track...
ash/drag_drop/drag_drop_tracker.cc:22:
window->SetBoundsInScreen(root_window->GetBoundsInScreen(),
Does dragging from the 2nd display to primary one work?
I'd like to make sure that the capture window can receive mouse events when
dragging starts in the 2nd root window.

[varunjain, 2012-10-01 02:59:06]

https://codereview.chromium.org/11009010/diff/1/ash/drag_drop/drag_drop_track...
File ash/drag_drop/drag_drop_tracker.cc (left):

https://codereview.chromium.org/11009010/diff/1/ash/drag_drop/drag_drop_track...
ash/drag_drop/drag_drop_tracker.cc:22:
window->SetBoundsInScreen(root_window->GetBoundsInScreen(),
On 2012/09/29 06:47:56, mazda wrote:
> Does dragging from the 2nd display to primary one work?
> I'd like to make sure that the capture window can receive mouse events when
> dragging starts in the 2nd root window.

seems to be working fine.

[mazda, 2012-10-01 17:15:14]

lgtm

[mazda, 2012-10-01 17:30:03]

http://codereview.chromium.org/11009010/diff/1/ash/drag_drop/drag_drop_tracke...
File ash/drag_drop/drag_drop_tracker.cc (left):

http://codereview.chromium.org/11009010/diff/1/ash/drag_drop/drag_drop_tracke...
ash/drag_drop/drag_drop_tracker.cc:17: aura::Window*
CreateCaptureWindow(aura::RootWindow* root_window) {
Could you delete |root_window| argument?

http://codereview.chromium.org/11009010/diff/1/ash/drag_drop/drag_drop_tracke...
ash/drag_drop/drag_drop_tracker.cc:33:
DragDropTracker::DragDropTracker(aura::RootWindow* root_window)
This one as well.

[varunjain, 2012-10-01 18:41:09]

PTAL

http://codereview.chromium.org/11009010/diff/1/ash/drag_drop/drag_drop_tracke...
File ash/drag_drop/drag_drop_tracker.cc (left):

http://codereview.chromium.org/11009010/diff/1/ash/drag_drop/drag_drop_tracke...
ash/drag_drop/drag_drop_tracker.cc:17: aura::Window*
CreateCaptureWindow(aura::RootWindow* root_window) {
On 2012/10/01 17:30:03, mazda wrote:
> Could you delete |root_window| argument?

Done.

http://codereview.chromium.org/11009010/diff/1/ash/drag_drop/drag_drop_tracke...
ash/drag_drop/drag_drop_tracker.cc:33:
DragDropTracker::DragDropTracker(aura::RootWindow* root_window)
On 2012/10/01 17:30:03, mazda wrote:
> This one as well.

Done.

[mazda, 2012-10-01 19:33:24]

http://codereview.chromium.org/11009010/diff/13001/ash/drag_drop/drag_drop_tr...
File ash/drag_drop/drag_drop_tracker_unittest.cc (right):

http://codereview.chromium.org/11009010/diff/13001/ash/drag_drop/drag_drop_tr...
ash/drag_drop/drag_drop_tracker_unittest.cc:35: static aura::Window*
GetTarget(aura::RootWindow* root_window,
Could you delete this |root_window| too?

http://codereview.chromium.org/11009010/diff/13001/ash/drag_drop/drag_drop_tr...
ash/drag_drop/drag_drop_tracker_unittest.cc:47: static ui::MouseEvent*
ConvertMouseEvent(aura::RootWindow* root_window,
Could you delete this one as well?

http://codereview.chromium.org/11009010/diff/13001/ash/drag_drop/drag_drop_tr...
ash/drag_drop/drag_drop_tracker_unittest.cc:80: 
I guess the active root window needs to be set to pass the test.

Shell::GetInstance()->set_active_root_window(root_windows[0]);

http://codereview.chromium.org/11009010/diff/13001/ash/drag_drop/drag_drop_tr...
ash/drag_drop/drag_drop_tracker_unittest.cc:98: 
Here too.

Shell::GetInstance()->set_active_root_window(root_windows[1]);

http://codereview.chromium.org/11009010/diff/13001/ash/drag_drop/drag_drop_tr...
ash/drag_drop/drag_drop_tracker_unittest.cc:139: 
Shell::GetInstance()->set_active_root_window(root_windows[0]);

http://codereview.chromium.org/11009010/diff/13001/ash/drag_drop/drag_drop_tr...
ash/drag_drop/drag_drop_tracker_unittest.cc:167: 
Shell::GetInstance()->set_active_root_window(root_windows[1]);

[varunjain, 2012-10-01 22:14:23]

Actually, it turns out that I still need to match the origin of the root window
to parent the capture window properly. Otherwise it changes functionality and
results in failing tests. I have changed the CL to do just that. PTAL

On 2012/10/01 19:33:24, mazda wrote:
>
http://codereview.chromium.org/11009010/diff/13001/ash/drag_drop/drag_drop_tr...
> File ash/drag_drop/drag_drop_tracker_unittest.cc (right):
> 
>
http://codereview.chromium.org/11009010/diff/13001/ash/drag_drop/drag_drop_tr...
> ash/drag_drop/drag_drop_tracker_unittest.cc:35: static aura::Window*
> GetTarget(aura::RootWindow* root_window,
> Could you delete this |root_window| too?
> 
>
http://codereview.chromium.org/11009010/diff/13001/ash/drag_drop/drag_drop_tr...
> ash/drag_drop/drag_drop_tracker_unittest.cc:47: static ui::MouseEvent*
> ConvertMouseEvent(aura::RootWindow* root_window,
> Could you delete this one as well?
> 
>
http://codereview.chromium.org/11009010/diff/13001/ash/drag_drop/drag_drop_tr...
> ash/drag_drop/drag_drop_tracker_unittest.cc:80: 
> I guess the active root window needs to be set to pass the test.
> 
> Shell::GetInstance()->set_active_root_window(root_windows[0]);
> 
>
http://codereview.chromium.org/11009010/diff/13001/ash/drag_drop/drag_drop_tr...
> ash/drag_drop/drag_drop_tracker_unittest.cc:98: 
> Here too.
> 
> Shell::GetInstance()->set_active_root_window(root_windows[1]);
> 
>
http://codereview.chromium.org/11009010/diff/13001/ash/drag_drop/drag_drop_tr...
> ash/drag_drop/drag_drop_tracker_unittest.cc:139: 
> Shell::GetInstance()->set_active_root_window(root_windows[0]);
> 
>
http://codereview.chromium.org/11009010/diff/13001/ash/drag_drop/drag_drop_tr...
> ash/drag_drop/drag_drop_tracker_unittest.cc:167: 
> Shell::GetInstance()->set_active_root_window(root_windows[1]);

[mazda, 2012-10-01 22:48:57]

lgtm

Thank you for looking into it.

[sky, 2012-10-01 23:25:52]

LGTM

[commit-bot: I haz the power, 2012-10-02 01:16:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/11009010/7007

[commit-bot: I haz the power, 2012-10-02 03:23:34]

Change committed as 159635