Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Unified Diff: src/trusted/validator_ragel/decoder_x86_32.rl

Issue 11000033: Move validator_x86_XX.rl out of unreviewed. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator_ragel/decoder_internal.h ('k') | src/trusted/validator_ragel/decoder_x86_64.rl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_ragel/decoder_x86_32.rl
===================================================================
--- src/trusted/validator_ragel/decoder_x86_32.rl (revision 11020)
+++ src/trusted/validator_ragel/decoder_x86_32.rl (working copy)
@@ -20,7 +20,7 @@
#include <string.h>
#include "native_client/src/shared/utils/types.h"
-#include "native_client/src/trusted/validator_ragel/unreviewed/decoder_internal.h"
+#include "native_client/src/trusted/validator_ragel/decoder_internal.h"
%%{
machine x86_32_decoder;
@@ -67,9 +67,9 @@
process_instruction(instruction_begin, current_position + 1, &instruction,
userdata);
instruction_begin = current_position + 1;
- SET_DISP_TYPE(DISPNONE);
- SET_IMM_TYPE(IMMNONE);
- SET_IMM2_TYPE(IMMNONE);
+ SET_DISPLACEMENT_FORMAT(DISPNONE);
+ SET_IMMEDIATE_FORMAT(IMMNONE);
+ SET_SECOND_IMMEDIATE_FORMAT(IMMNONE);
SET_DATA16_PREFIX(FALSE);
SET_LOCK_PREFIX(FALSE);
SET_REPNZ_PREFIX(FALSE);
@@ -90,6 +90,10 @@
$!report_fatal_error;
}%%
+/*
+ * The "write data" statement causes Ragel to emit the constant static data
+ * needed by the ragel machine.
+ */
%% write data;
int DecodeChunkIA32(const uint8_t *data, size_t size,
@@ -108,7 +112,15 @@
memset(&instruction, 0, sizeof instruction);
+ /*
+ * The "write init" statement causes Ragel to emit initialization code.
+ * This should be executed once before the ragel machine is started.
+ */
%% write init;
+ /*
+ * The "write exec" statement causes Ragel to emit the ragel machine's
+ * execution code.
+ */
%% write exec;
error_detected:
« no previous file with comments | « src/trusted/validator_ragel/decoder_internal.h ('k') | src/trusted/validator_ragel/decoder_x86_64.rl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698