Issue 11000027: Rename GetSite in SiteInstance to GetSiteURL.

Issue 11000027: Rename GetSite in SiteInstance to GetSiteURL. (Closed)

Created:
8 years, 2 months ago by nasko

Modified:
8 years, 2 months ago

Reviewers:
Charlie Reis, Mihai Parparita -not on Chrome, brettw

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, groby+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, rouslan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename GetSite in SiteInstance to GetSiteURL. This rename is in preparation of adding a GetSite method, which will return a structure instead of GURL. BUG=145500 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159263

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -29 lines)			Patch
M	chrome/browser/chrome_content_browser_client.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_process_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_view_host_observer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/browser_context.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/browser_plugin/browser_plugin_embedder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/browser_plugin/old/old_browser_plugin_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/browsing_instance.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/intents/intent_injector.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/pepper/pepper_message_filter.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_manager_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/site_instance_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/site_instance_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/site_instance_impl_unittest.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/web_contents/navigation_controller_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/navigation_controller_impl_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/render_view_host_manager.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/web_contents/render_view_host_manager_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/site_instance.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

nasko

Hey Charlie, Can you review this rename of GetSite in SiteInstance to GetSiteURL? Thanks, Nasko

8 years, 2 months ago (2012-09-27 15:01:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/11000027/1

8 years, 2 months ago (2012-09-27 21:12:40 UTC) #3

commit-bot: I haz the power

Presubmit check for 11000027-1 failed and returned exit status 1. Running presubmit commit checks ...

8 years, 2 months ago (2012-09-27 21:12:57 UTC) #4

nasko

Including OWNERS reviewers: mihaip -> chrome/browser/extensions brettw -> chrome/

8 years, 2 months ago (2012-09-27 21:15:24 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/11000027/1

8 years, 2 months ago (2012-09-28 14:15:25 UTC) #8

Change committed as 159263

Expand Messages | Collapse Messages