Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/metrics/variations/variations_service.cc

Issue 10996067: Measure and log the latency of VariationsService requests. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Medium times and no helper Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/variations/variations_service.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/variations/variations_service.cc
diff --git a/chrome/browser/metrics/variations/variations_service.cc b/chrome/browser/metrics/variations/variations_service.cc
index 87a4ed954a70370fbae8d7821860044d97a8eb2c..aa18951cbead00654a1ceb8be75376a0bee39f3a 100644
--- a/chrome/browser/metrics/variations/variations_service.cc
+++ b/chrome/browser/metrics/variations/variations_service.cc
@@ -183,6 +183,8 @@ void VariationsService::DoActualFetch() {
variations_serial_number_);
}
pending_seed_request_->Start();
+
+ last_request_started_time_ = base::TimeTicks::Now();
}
void VariationsService::FetchVariationsSeed() {
@@ -211,11 +213,19 @@ void VariationsService::OnURLFetchComplete(const net::URLFetcher* source) {
net::HttpUtil::MapStatusCodeForHistogram(request->GetResponseCode()),
net::HttpUtil::GetStatusCodesForHistogram());
+ const base::TimeDelta latency =
+ base::TimeTicks::Now() - last_request_started_time_;
+
if (request->GetResponseCode() != 200) {
DVLOG(1) << "Variations server request returned non-200 response code: "
<< request->GetResponseCode();
+ if (request->GetResponseCode() == 304)
+ UMA_HISTOGRAM_MEDIUM_TIMES("Variations.FetchNotModifiedLatency", latency);
+ else
+ UMA_HISTOGRAM_MEDIUM_TIMES("Variations.FetchOtherLatency", latency);
return;
}
+ UMA_HISTOGRAM_MEDIUM_TIMES("Variations.FetchSuccessLatency", latency);
std::string seed_data;
bool success = request->GetResponseAsString(&seed_data);
« no previous file with comments | « chrome/browser/metrics/variations/variations_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698